From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: David Turner <dturner@twopensource.com>
Cc: git@vger.kernel.org, mhagger@alum.mit.edu, gitster@pobox.com,
David Turner <dturner@twitter.com>
Subject: Re: [PATCH] check_refname_component: Optimize
Date: Thu, 29 May 2014 12:19:26 +0000 [thread overview]
Message-ID: <20140529121926.GA47385@vauxhall.crustytoothpaste.net> (raw)
In-Reply-To: <1401307055-11603-1-git-send-email-dturner@twitter.com>
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
On Wed, May 28, 2014 at 03:57:35PM -0400, David Turner wrote:
> +ifdef NO_SSE
> + BASIC_CFLAGS += -DNO_SSE
This is not a great name. This implies the system does not have SSE
(SSE 1), but in fact what you're concerned about is SSE 4. This will be
confusing for users of older x86-64 processors, where SSE and SSE 2 are
architecturally guaranteed even though SSE 4 is not present.
> +else
> + BASIC_CFLAGS += -msse4
> +endif
You probably also want to autodetect when the system is not x86(-64)?
and turn this off. I doubt PowerPC/SPARC/ARM users are going to want to
have to disable it manually.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-05-29 12:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 19:57 [PATCH] check_refname_component: Optimize David Turner
2014-05-28 21:24 ` Junio C Hamano
2014-05-29 12:19 ` brian m. carlson [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-05-28 21:04 [PATCH v2 0/1] " David Turner
2014-05-28 21:04 ` [PATCH] " David Turner
2014-05-28 21:44 ` Michael Haggerty
2014-05-28 23:49 ` David Turner
2014-05-29 13:41 ` Duy Nguyen
2014-05-29 16:36 ` Junio C Hamano
2014-05-29 23:24 ` Duy Nguyen
2014-05-29 23:41 ` Jeff King
2014-05-29 23:43 ` Duy Nguyen
2014-05-30 0:07 ` Jeff King
2014-05-30 2:03 ` Duy Nguyen
2014-05-30 9:47 ` Michael Haggerty
2014-05-30 17:29 ` Jeff King
2014-05-31 10:47 ` Michael Haggerty
2014-05-31 11:21 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140529121926.GA47385@vauxhall.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=dturner@twitter.com \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).