git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Azat Khuzhin <a3at.mail@gmail.com>
To: git@vger.kernel.org, mhagger@alum.mit.edu
Subject: git-multimail: migration: Config is not iterable
Date: Thu, 29 May 2014 18:22:08 +0400	[thread overview]
Message-ID: <20140529142208.GB27005@azat> (raw)

Hi there,

Using the latest version of git-multimail there is an issue with
migration:

$ ~azat/git-multimail/git-multimail/migrate-mailhook-config --overwrite
Traceback (most recent call last):
  File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 271, in <module>
    main(sys.argv[1:])
  File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 268, in main
    migrate_config(strict=options.strict, retain=options.retain, overwrite=options.overwrite)
  File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 159, in migrate_config
    if not _check_old_config_exists(old):
  File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 66, in _check_old_config_exists
    if name in old:
TypeError: argument of type 'Config' is not iterable

Tested on 2.6 and 2.7 python versions.

If you revert 09d0d5b92203f019763e43cef1e57f76f117d2b4 ("Get Python files to
pass pep8's tests.") there issue goes away. I understand that this is not the
right solution and I'm not the guru of python, so just let you know.

Thanks

             reply	other threads:[~2014-05-29 14:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 14:22 Azat Khuzhin [this message]
2014-05-29 16:06 ` git-multimail: migration: Config is not iterable Elijah Newren
2014-05-31 14:59 ` Michael Haggerty
2014-05-31 15:21   ` Azat Khuzhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140529142208.GB27005@azat \
    --to=a3at.mail@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=mhagger@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).