From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [puzzled and solved] "shortlog" not quite understanding all "log" options
Date: Fri, 30 May 2014 16:16:53 -0400 [thread overview]
Message-ID: <20140530201652.GC5513@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqzjhz83rk.fsf@gitster.dls.corp.google.com>
On Fri, May 30, 2014 at 12:28:47PM -0700, Junio C Hamano wrote:
> .... Aaaand, it turns out that the answer is in the big comment at
> the beginning of handle_revision_pseudo_opt().
>
> -- >8 --
> Subject: shortlog: allow --exclude=<glob> to be passed
>
> e7b432c5 (revision: introduce --exclude=<glob> to tame wildcards,
> 2013-08-30) taught a new option to the command-line parser of "log"
> and friends, but did not wire it fully so that it can also be used
> by "shortlog".
FWIW, I think the discussion above the scissors adds a lot to the
context. It might be nice to add it to the commit message.
I am slightly puzzled why parse_revision_opt does not just call
handle_revision_pseudo_opt. According to f6aca0dc4, it is because
pseudo-options need to be acted on in-order, as they affect things like
subsequent "--not" options, etc. But if we are using parse_options_step,
shouldn't we be handling the options in order?
I am sure I am just missing something obvious, so do not trouble
yourself if you do not know the answer offhand.
-Peff
next prev parent reply other threads:[~2014-05-30 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 19:28 [puzzled and solved] "shortlog" not quite understanding all "log" options Junio C Hamano
2014-05-30 20:16 ` Jeff King [this message]
2014-05-30 21:37 ` Junio C Hamano
2014-06-18 8:08 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530201652.GC5513@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).