From: Jeff King <peff@peff.net>
To: Eddie Monge <eddie@eddiemonge.com>
Cc: git@vger.kernel.org
Subject: Re: Git stash gpg prompting
Date: Fri, 30 May 2014 16:24:14 -0400 [thread overview]
Message-ID: <20140530202413.GD5513@sigill.intra.peff.net> (raw)
In-Reply-To: <CALp-zYGRLKJfC5rVygRg8adjsxP0h2dguNSYsvmcZxq7tcEQfg@mail.gmail.com>
On Fri, May 30, 2014 at 01:07:16PM -0700, Eddie Monge wrote:
> Git stash is prompting for passphrase to try to "sign" the changes
> being stashed.
>
> Reproduce:
> Add to global gitconfig with signing key:
> ```
> [commit]
> gpgsign = true
> ```
> Go to a repo, make some changes, and then run `git stash`
>
> Expected: stash the changes as normal
> Actual: git prompts for passphrase (if set)
Well, yeah...stash is making a commit (two, actually), so it wants you
to sign it. :)
I suspect that using "git notes" has a similar problem. I can see an
argument for not signing stashes, as they are meant to be temporary and
not shared. I do think notes probably should be signed.
However, I wonder if it is really ever going to be sane to set
commit.gpgsign and not use something like gpg-agent. For example, if you
were to ever "git rebase" a patch series (or even just use "git rebase
-i" to refactor commits), you would be prompted for your passphrase to
sign each individual patch.
-Peff
next prev parent reply other threads:[~2014-05-30 20:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 20:07 Git stash gpg prompting Eddie Monge
2014-05-30 20:24 ` Jeff King [this message]
2014-05-30 20:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530202413.GD5513@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=eddie@eddiemonge.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).