From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [RFC PATCH] git log: support "auto" decorations
Date: Fri, 30 May 2014 16:48:53 -0400 [thread overview]
Message-ID: <20140530204853.GA9271@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqmwdz809b.fsf@gitster.dls.corp.google.com>
On Fri, May 30, 2014 at 01:44:32PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Subject: [PATCH] reuse commit->buffer when parsing signatures
> > ...
> > Signed-off-by: Jeff King <peff@peff.net>
>
> Hmph, unfortunately this seems to break t7510.
Urgh, sorry for not testing more thoroughly.
I imagine it is because of the strlen(commit->buffer) I introduced.
Unfortunately I do not know if we have an easy way to know the length of
commit->buffer, short of hitting sha1_object_info (which is somewhat
expensive to do for every commit).
I wonder if it would be sane to remove or quote NULs when attaching the
buffer to commit->buffer. That would _break_ signatures, but that is a
good thing. I do not think there is a reason to have NULs in your commit
message unless you are doing something malicious (or using utf16, but
that already is horribly broken).
-Peff
next prev parent reply other threads:[~2014-05-30 20:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 22:31 [RFC PATCH] git log: support "auto" decorations Linus Torvalds
2014-05-30 1:58 ` Jeff King
2014-05-30 4:54 ` Linus Torvalds
2014-05-30 6:57 ` Jeff King
2014-05-30 16:55 ` Junio C Hamano
2014-05-30 17:03 ` Jeff King
2014-05-30 17:35 ` Junio C Hamano
2014-05-30 18:34 ` Jeff King
2014-05-30 18:39 ` Jeff King
2014-05-30 20:44 ` Junio C Hamano
2014-05-30 20:48 ` Jeff King [this message]
2014-05-30 21:13 ` Junio C Hamano
2014-05-30 20:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530204853.GA9271@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).