From: Jeremiah Mahler <jmmahler@gmail.com>
To: Chris Packham <judge.packham@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 2/2] connect.c: replace signal() with sigaction()
Date: Sat, 31 May 2014 07:45:16 -0700 [thread overview]
Message-ID: <20140531144516.GA22508@hudson.localdomain> (raw)
In-Reply-To: <5389B16B.6070004@gmail.com>
Chris,
On Sat, May 31, 2014 at 10:39:39PM +1200, Chris Packham wrote:
> On 31/05/14 08:58, Jeremiah Mahler wrote:
> > From signal(2) man page:
> >
...
> > - signal(SIGCHLD, SIG_DFL);
> > + memset(&sa, 0, sizeof(sa));
> > + sa.sa_handler = SIG_DFL;
> > + sigaction(SIGCHLD, &sa, 0);
>
> I think this got lost in the wash with v1 but
> Documentation/CodingGuidelines says to use NULL here instead of 0.
>
Got it. Will be in to the next revision.
sigaction(SIGCHLD, &sa, NULL);
Thanks,
--
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler
prev parent reply other threads:[~2014-05-31 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 20:58 [PATCH v2 0/2] replace signal() with sigaction() Jeremiah Mahler
2014-05-30 20:58 ` [PATCH v2 1/2] compat/mingw.c: expand MinGW support for sigaction Jeremiah Mahler
2014-05-30 20:58 ` [PATCH v2 2/2] connect.c: replace signal() with sigaction() Jeremiah Mahler
2014-05-30 21:48 ` Andreas Schwab
2014-05-31 10:39 ` Chris Packham
2014-05-31 14:45 ` Jeremiah Mahler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140531144516.GA22508@hudson.localdomain \
--to=jmmahler@gmail.com \
--cc=git@vger.kernel.org \
--cc=judge.packham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).