From: Jeff King <peff@peff.net>
To: "Naumov, Michael (North Sydney)" <Michael.Naumov@Fiserv.com>
Cc: Junio C Hamano <gitster@pobox.com>, git <git@vger.kernel.org>,
"spearce@spearce.org" <spearce@spearce.org>,
"j6t@kdbg.org" <j6t@kdbg.org>, "nico@cam.org" <nico@cam.org>,
"junkio@cox.net" <junkio@cox.net>,
"kusmabite@gmail.com" <kusmabite@gmail.com>,
"mnaoumov@gmail.com" <mnaoumov@gmail.com>
Subject: Re: [PATCH] sideband.c: Get rid of ANSI sequences for non-terminal shell
Date: Mon, 2 Jun 2014 02:30:00 -0400 [thread overview]
Message-ID: <20140602062959.GA27254@sigill.intra.peff.net> (raw)
In-Reply-To: <81E85F13A4BE084BAF4B1AA24173EDA0144E14B7@JWPKEXMBX03.corp.checkfree.com>
On Fri, May 30, 2014 at 11:10:51PM +0000, Naumov, Michael (North Sydney) wrote:
> Some git tools such as GitExtensions for Windows use environment
> variable TERM=msys which causes the weird ANSI sequence shown for the
> messages returned from server-side hooks
> We add those ANSI sequences to help format sideband data on the user's
> terminal. However, GitExtensions is not using a terminal, and the ANSI
> sequences just confuses it. We can recognize this use by checking
> isatty().
> See https://github.com/gitextensions/gitextensions/issues/1313 for
> more details
>
> NOTE: I considered to cover the case that a pager has already been
> started. But decided that is probably not worth worrying about here,
> though, as we shouldn't be using a pager for commands that do network
> communications (and if we do, omitting the magic line-clearing signal
> is probably a sane thing to do).
>
> Signed-off-by: Michael Naumov <mnaoumov@gmail.com>
> Thanks-to: Erik Faye-Lund <kusmabite@gmail.com>
> Thanks-to: Jeff King <peff@peff.net>
This version looks fine to me.
-Peff
next prev parent reply other threads:[~2014-06-02 6:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 23:10 [PATCH] sideband.c: Get rid of ANSI sequences for non-terminal shell Naumov, Michael (North Sydney)
2014-06-02 6:30 ` Jeff King [this message]
2014-06-02 17:59 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2014-06-02 23:40 Naumov, Michael (North Sydney)
2014-05-28 3:12 Naumov, Michael (North Sydney)
2014-05-29 17:45 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602062959.GA27254@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Michael.Naumov@Fiserv.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=junkio@cox.net \
--cc=kusmabite@gmail.com \
--cc=mnaoumov@gmail.com \
--cc=nico@cam.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).