From: Stepan Kasal <kasal@ucw.cz>
To: Thomas Braun <thomas.braun@virtuell-zuhause.de>
Cc: GIT Mailing-list <git@vger.kernel.org>, msysgit@googlegroups.com
Subject: Re: [PATCH] t5000, t5003: do not use test_cmp to compare binary files
Date: Wed, 4 Jun 2014 14:42:57 +0200 [thread overview]
Message-ID: <20140604124257.GA22415@camelia.ucw.cz> (raw)
In-Reply-To: <538F0D78.3020708@virtuell-zuhause.de>
Hello Thomas,
On Wed, Jun 04, 2014 at 02:13:44PM +0200, Thomas Braun wrote:
> Wouldn't a function like test_cmp_bin() be better suited for all?
I also considered it. The advantage is that is shows that
this intentionally differs from test_cmp.
> The windows folks can then use cmp inside test_cmp_bin() and all others
... would use cmp as well because it is better suited for the task
than diff -u. So test_cmp_bin would be just an alias for cmp, on all
platforms. Doesn't that sound weird?
Stepan
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2014-06-04 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 11:42 [PATCH] t5000, t5003: do not use test_cmp to compare binary files Stepan Kasal
2014-06-04 12:13 ` Thomas Braun
2014-06-04 12:42 ` Stepan Kasal [this message]
2014-06-04 12:59 ` Thomas Braun
2014-06-04 15:57 ` [PATCH v2] " Stepan Kasal
2014-06-04 18:22 ` Junio C Hamano
2014-06-05 2:01 ` Michael Geddes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140604124257.GA22415@camelia.ucw.cz \
--to=kasal@ucw.cz \
--cc=git@vger.kernel.org \
--cc=msysgit@googlegroups.com \
--cc=thomas.braun@virtuell-zuhause.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).