From: Stepan Kasal <kasal@ucw.cz>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Karsten Blees <karsten.blees@gmail.com>,
Erik Faye-Lund <kusmabite@gmail.com>,
Duy Nguyen <pclouds@gmail.com>,
GIT Mailing-list <git@vger.kernel.org>,
Thomas Braun <thomas.braun@virtuell-zuhause.de>,
msysGit <msysgit@googlegroups.com>
Subject: Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");
Date: Thu, 5 Jun 2014 14:15:21 +0200 [thread overview]
Message-ID: <20140605121521.GA28894@camelia.ucw.cz> (raw)
In-Reply-To: <alpine.DEB.1.00.1406051354000.14982@s15462909.onlinehome-server.info>
Hi,
On Thu, Jun 05, 2014 at 02:03:39PM +0200, Johannes Schindelin wrote:
> Render me even more convinced that the API call is the cleanest way to go,
But not me.
In a paralel post, Duy Nguyen wrote:
> Thank you for working on pushing msysgit patches upstream. I don't use
> git on windows, but it's nice to see all windows-specific changes in
> one code base so we can try to workaround it when new patches/features
> are developed.
... but we should not obscure that more than necessary. If the API
call is getenv("HOME"); it helps. And the hack with
mingw_getenv() is not that bad, so we should be pragmatic and accept
it.
Stepan
next prev parent reply other threads:[~2014-06-05 12:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 11:47 [PATCH] Add a Windows-specific fallback to getenv("HOME"); Stepan Kasal
2014-06-04 13:47 ` Duy Nguyen
2014-06-04 14:05 ` Erik Faye-Lund
2014-06-04 14:55 ` Karsten Blees
2014-06-04 15:14 ` Johannes Schindelin
2014-06-04 15:18 ` Erik Faye-Lund
2014-06-04 15:27 ` Johannes Schindelin
2014-06-04 15:45 ` Stepan Kasal
2014-06-04 15:56 ` [msysGit] " Johannes Schindelin
2014-06-04 16:16 ` Stepan Kasal
2014-06-04 17:49 ` [msysGit] " Johannes Schindelin
2014-06-06 9:12 ` Git for Windows SDK Philip Oakley
2014-06-04 23:10 ` Re: [PATCH] Add a Windows-specific fallback to getenv("HOME"); Duy Nguyen
2014-06-06 19:26 ` Sebastian Schuberth
2014-06-04 15:46 ` Johannes Schindelin
2014-06-05 1:42 ` Karsten Blees
2014-06-05 8:03 ` [PATCH v2] " Stepan Kasal
2014-06-05 8:32 ` [msysGit] " Torsten Bögershausen
2014-06-05 10:23 ` [PATCH v3] " Stepan Kasal
2014-06-05 9:40 ` [PATCH v2] " Karsten Blees
2014-06-05 9:58 ` Erik Faye-Lund
2014-06-05 21:44 ` Karsten Blees
2014-06-06 8:03 ` Stepan Kasal
2014-06-05 11:23 ` Stepan Kasal
2014-06-05 13:39 ` Johannes Schindelin
2014-06-05 20:03 ` Karsten Blees
2014-06-05 12:03 ` Re: [PATCH] " Johannes Schindelin
2014-06-05 12:15 ` Stepan Kasal [this message]
2014-06-05 14:33 ` Karsten Blees
2014-06-04 14:53 ` Stepan Kasal
2014-06-04 15:13 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605121521.GA28894@camelia.ucw.cz \
--to=kasal@ucw.cz \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=karsten.blees@gmail.com \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=pclouds@gmail.com \
--cc=thomas.braun@virtuell-zuhause.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).