From: Stepan Kasal <kasal@ucw.cz>
To: Karsten Blees <karsten.blees@gmail.com>
Cc: GIT Mailing-list <git@vger.kernel.org>,
msysGit <msysgit@googlegroups.com>
Subject: Re: [msysGit] Re: [PATCH] mingw: redefine the wrapper macro after the corresponding function
Date: Thu, 5 Jun 2014 17:13:38 +0200 [thread overview]
Message-ID: <20140605151338.GA29385@camelia.ucw.cz> (raw)
In-Reply-To: <539083FB.6040707@gmail.com>
Hello Karsten,
On Thu, Jun 05, 2014 at 04:51:39PM +0200, Karsten Blees wrote:
> In the current msysgit HEAD, most of these #undef's can simply be
> removed or have already been removed [...]
not "most of." According to my quick count, 6 of 20 have been removed,
2 more can be removed. The remaining 12 do play their role.
(The point you overlooked is that there are several socket related,
like bind().)
> If you apply this patch in msysgit, you'll most likely get compile
> errors due to redefining macros.
It would be warnings only. But a quick test shows that redefining
with identical definition does not trigger the warning.
Stepan
next prev parent reply other threads:[~2014-06-05 15:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 8:05 [PATCH] mingw: redefine the wrapper macro after the corresponding function Stepan Kasal
2014-06-05 14:51 ` Karsten Blees
2014-06-05 15:13 ` Stepan Kasal [this message]
2014-06-05 22:12 ` Karsten Blees
2014-06-05 16:56 ` [msysGit] " Johannes Sixt
2014-06-05 22:00 ` Karsten Blees
2014-06-06 8:32 ` Stepan Kasal
2014-06-06 8:41 ` [PATCH v2] " Stepan Kasal
2014-06-06 9:43 ` [PATCH] " Karsten Blees
2014-06-06 11:10 ` Stepan Kasal
2014-06-06 18:20 ` Karsten Blees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605151338.GA29385@camelia.ucw.cz \
--to=kasal@ucw.cz \
--cc=git@vger.kernel.org \
--cc=karsten.blees@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).