git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Caleb Thompson <caleb@calebthompson.io>
To: Jeremiah Mahler <jmmahler@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v4 1/4] commit test: Use test_config instead of git-config
Date: Thu, 12 Jun 2014 13:23:41 -0500	[thread overview]
Message-ID: <20140612182341.GA42013@sirius.local> (raw)
In-Reply-To: <20140612180830.GB15556@hudson.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]

Jeremiah,

On Thu, Jun 12, 2014 at 11:04:59AM -0700, Jeremiah Mahler wrote:
>
> Thanks for checking.  Unfortunately the problem persists for me.
>
> It seems to be related to there not being a space at the left most part
> of the patch.  It is just a tab with no space.  So 'git am' has a
> problem because it is expecting to remove a space and there isn't one.
> See the attached screenshots with tabs highlighted.
>
> How are you preparing your patches.  'git format-patch' with a 'git
> send-email'?

I'm so glad you asked, because I've just been muddling through this.

I've been generating the cover page variously with request-pull or diff
--stat, then running a command like this, with --cc arguments added from
a list I've been keeping of people who respond to the threads:

    git send-email --compose --to=git@vger.kernel.org --thread \
        [--cc ...] --no-chain-reply origin/master...

Then I manually edit the subjects to add the version to the [PATCH N/M]
portions. I haven't been using format-patch.

It's interesting that only the first patch isn't applying. I'd love to
hear a better way.

Caleb

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2014-06-12 18:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11 18:24 [PATCH v4 0/4] commit: support commit.verbose and --no-verbose caleb
2014-06-11 18:24 ` [PATCH v4 1/4] commit test: Use test_config instead of git-config caleb
2014-06-12  8:41   ` Jeremiah Mahler
2014-06-12 13:51     ` Caleb Thompson
2014-06-12 18:04       ` Jeremiah Mahler
2014-06-12 18:08         ` Jeremiah Mahler
2014-06-12 18:23           ` Caleb Thompson [this message]
2014-06-12 18:46             ` Jeremiah Mahler
2014-06-12 19:23               ` Caleb Thompson
2014-06-11 18:24 ` [PATCH v4 2/4] commit test: Use write_script caleb
2014-06-11 18:24 ` [PATCH v4 3/4] commit test: test_set_editor in each test caleb
2014-06-11 18:24 ` [PATCH v4 4/4] commit: support commit.verbose and --no-verbose caleb
2014-06-11 20:41   ` René Scharfe
2014-06-11 21:26     ` Caleb Thompson
2014-06-12 14:36       ` Caleb Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140612182341.GA42013@sirius.local \
    --to=caleb@calebthompson.io \
    --cc=git@vger.kernel.org \
    --cc=jmmahler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).