From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: nori <semtlenori@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] http: fix charset detection of extract_content_type()
Date: Mon, 16 Jun 2014 15:20:05 -0400 [thread overview]
Message-ID: <20140616192005.GA19322@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqha3kr9m4.fsf@gitster.dls.corp.google.com>
On Mon, Jun 16, 2014 at 11:29:39AM -0700, Junio C Hamano wrote:
> nori <semtlenori@gmail.com> writes:
>
> > extract_content_type() could not extract a charset parameter if the
> > parameter is not the first one and there is a whitespace and a following
> > semicolon just before the parameter. For example:
> >
> > text/plain; format=fixed ;charset=utf-8
> >
> > Signed-off-by: Yi EungJun <eungjun.yi@navercorp.com>
> > ---
>
> Peff, doesn't this look somehow familiar? Perhaps with e3131626
> (http: optionally extract charset parameter from content-type,
> 2014-05-22), this patch is unnecessary?
No, I think this is built on top of e3131626 to catcha case I mised. It
looks OK at first glance, but I'd really like to add better test
coverage for this parsing.
-Peff
next prev parent reply other threads:[~2014-06-16 19:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-14 18:49 [PATCH] http: fix charset detection of extract_content_type() nori
2014-06-15 8:21 ` Yi EungJun
2014-06-16 18:29 ` Junio C Hamano
2014-06-16 19:20 ` Jeff King [this message]
2014-06-17 9:31 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140616192005.GA19322@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=semtlenori@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).