git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeremiah Mahler <jmmahler@gmail.com>
Cc: git@vger.kernel.org, "Torsten Bögershausen" <tboegi@web.de>
Subject: Re: [PATCH v2 0/3] add strnncmp() function
Date: Tue, 17 Jun 2014 10:48:17 -0700	[thread overview]
Message-ID: <20140617174817.GQ8557@google.com> (raw)
In-Reply-To: <20140617154953.GC5162@hudson.localdomain>

>> On 2014-06-17 09.34, Jeremiah Mahler wrote:

>>> Also, strnncmp() was switched from using memcmp() to strncmp()
>>> internally to make it clear that this is meant for strings, not
>>> general buffers.

Why shouldn't I want to use this helper on arbitrary data?  One of the
advantages of other helpers in git that take a pointer and a length
(e.g., the strbuf library) are that they are 8-bit clean and can work
on binary data when it's useful.

Thanks,
Jonathan

  reply	other threads:[~2014-06-17 17:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-17  7:34 [PATCH v2 0/3] add strnncmp() function Jeremiah Mahler
2014-06-17  7:34 ` [PATCH v2 1/3] " Jeremiah Mahler
2014-06-17  8:23   ` Torsten Bögershausen
2014-06-17 15:48     ` Jeremiah Mahler
2014-06-17  9:09   ` Erik Faye-Lund
2014-06-17 15:49     ` Jeremiah Mahler
2014-06-17 17:55   ` Junio C Hamano
2014-06-17 19:27     ` Jeremiah Mahler
2014-06-17  7:34 ` [PATCH v2 2/3] tree-walk: simplify via strnncmp() Jeremiah Mahler
2014-06-17  7:34 ` [PATCH v2 3/3] unpack-trees: " Jeremiah Mahler
2014-06-17 11:08 ` [PATCH v2 0/3] add strnncmp() function Torsten Bögershausen
2014-06-17 15:49   ` Jeremiah Mahler
2014-06-17 17:48     ` Jonathan Nieder [this message]
2014-06-17 19:09       ` Jeremiah Mahler
2014-06-18 10:33   ` Ondřej Bílka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140617174817.GQ8557@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jmmahler@gmail.com \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).