From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Caleb Thompson <caleb@calebthompson.io>,
git@vger.kernel.org, Jeremiah Mahler <jmmahler@gmail.com>
Subject: Re: [PATCH v6 4/4] commit: Add commit.verbose configuration
Date: Tue, 17 Jun 2014 17:39:28 -0400 [thread overview]
Message-ID: <20140617213926.GA18994@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqy4wvjjyu.fsf@gitster.dls.corp.google.com>
On Tue, Jun 17, 2014 at 02:37:45PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > On Tue, Jun 17, 2014 at 02:39:00PM -0500, Caleb Thompson wrote:
> >
> >> diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh
> >> index 35a4d06..471bd8f 100755
> >> --- a/t/t7507-commit-verbose.sh
> >> +++ b/t/t7507-commit-verbose.sh
> >> @@ -7,6 +7,10 @@ write_script check-for-diff <<-'EOF'
> >> exec grep '^diff --git' "$1"
> >> EOF
> >>
> >> +write_script check-for-no-diff <<-'EOF'
> >> + ! check-for-diff
> >> +EOF
> >
> > Don't you need "$PWD/" or similar here, since check-for-diff is not in our path?
>
> I actually would prefer a simpler
>
> ! grep '^diff --git' "$1"
>
> that does not depend on what other parts of the tests have done.
Yeah, if it is that simple, I would agree (I did not even look at the
definition of check-for-diff, and assumed it was more complicated :) ).
-Peff
next prev parent reply other threads:[~2014-06-17 21:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 19:38 [PATCH v6 0/4] commit: Add commit.verbose configuration Caleb Thompson
2014-06-17 19:38 ` [PATCH v6 1/4] commit test: Use test_config instead of git-config Caleb Thompson
2014-06-17 21:31 ` Junio C Hamano
2014-06-17 21:35 ` Junio C Hamano
2014-06-17 19:38 ` [PATCH v6 2/4] commit test: Use write_script Caleb Thompson
2014-06-17 19:38 ` [PATCH v6 3/4] commit test: test_set_editor in each test Caleb Thompson
2014-06-17 19:39 ` [PATCH v6 4/4] commit: Add commit.verbose configuration Caleb Thompson
2014-06-17 21:21 ` Jeff King
2014-06-17 21:37 ` Junio C Hamano
2014-06-17 21:39 ` Jeff King [this message]
2015-02-27 9:13 ` [PATCH v6 0/4] " Torstein Hegge
2015-03-02 19:02 ` Caleb Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617213926.GA18994@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=caleb@calebthompson.io \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jmmahler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).