From: Max Kirillov <max@max630.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Paul Mackerras <paulus@samba.org>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] gitk: refactor: separate generic hunk parsing out of find_hunk_blamespecs{}
Date: Tue, 24 Jun 2014 21:27:12 +0300 [thread overview]
Message-ID: <20140624182712.GA31008@wheezy.local> (raw)
In-Reply-To: <CAPig+cRv6851TWgRU6sBorKYZ0ABXv+a3oi=hrGjxYz9P6T7mg@mail.gmail.com>
On Mon, Feb 03, 2014 at 06:20:36PM -0500, Eric Sunshine wrote:
> On Mon, Feb 3, 2014 at 5:41 PM, Max Kirillov <max@max630.net> wrote:
>> For requesting a region blame, it is necessary to parse a hunk and
>> find the region in the parent file corresponding to the selected region.
>> There is already hunk parsin functionality in the find_hunk_blamespec{},
>
> s/parsin/parsing/
> s/in the/in/
>
>> but returns only information for a single line.
>
> s/but/but it/
>
Thank you!
--
Max
next prev parent reply other threads:[~2014-06-24 18:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 20:53 [PATCH] gitk: use single blamestuff for all show_line_source{} calls Max Kirillov
2014-02-03 22:34 ` [PATCH 0/3] gitk: show latest change to region Max Kirillov
2014-02-03 22:41 ` [PATCH 1/3] gitk: refactor: separate generic hunk parsing out of find_hunk_blamespecs{} Max Kirillov
2014-02-03 23:20 ` Eric Sunshine
2014-06-24 18:27 ` Max Kirillov [this message]
2014-02-03 22:42 ` [PATCH 2/3] gitk: refactor: separate io from logic in the searching origin of line Max Kirillov
2014-02-03 22:42 ` [PATCH 3/3] gitk: pick selection for region blame Max Kirillov
2014-02-03 22:48 ` [PATCH 3/3 v2] gitk: show latest change to region Max Kirillov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140624182712.GA31008@wheezy.local \
--to=max@max630.net \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).