From: Jonathan Nieder <jrnieder@gmail.com>
To: Ronnie Sahlberg <sahlberg@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] enums: remove trailing ',' after last item in enum
Date: Wed, 2 Jul 2014 12:58:05 -0700 [thread overview]
Message-ID: <20140702195805.GD5816@google.com> (raw)
In-Reply-To: <1404325445-17914-1-git-send-email-sahlberg@google.com>
Ronnie Sahlberg wrote:
> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
> ---
> builtin/clean.c | 2 +-
> builtin/tag.c | 2 +-
> pretty.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
Is there some gcc option or other tool that can automatically detect
this kind of problem so the regress/fix cycle doesn't have to repeat
too many times?
Looks like v1.7.2-rc0~32^2~16 (2010-03-14) and v1.7.4.2~34 (2011-03-16)
tried to fix this in the past.
Using the test from v1.7.4.2~34 also finds enums with trailing comma
in
grep.h
log-tree.c
Thanks,
Jonathan
next prev parent reply other threads:[~2014-07-02 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 18:24 [PATCH] enums: remove trailing ',' after last item in enum Ronnie Sahlberg
2014-07-02 19:58 ` Jonathan Nieder [this message]
2014-07-02 20:08 ` Ronnie Sahlberg
2014-07-09 14:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702195805.GD5816@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=sahlberg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).