From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] tag: support configuring --sort via .gitconfig
Date: Thu, 10 Jul 2014 15:34:04 -0400 [thread overview]
Message-ID: <20140710193404.GA15615@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqa98h8587.fsf@gitster.dls.corp.google.com>
On Thu, Jul 10, 2014 at 10:59:36AM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > I know this is existing code you are moving, but I noticed it looks ripe
> > for using skip_prefix. Perhaps while we are in the area we should do the
> > following on top of your patch (I'd also be happy for it be squashed
> > in, but that may be too much in one patch).
>
> I am tempted to suggest going the other way around, i.e. queue (an
> equivalent of) this on jk/skip-prefix and merge it to 'next' and
> then 'master' quickly.
>
> I can go either way, but I tend to prefer building new things on top
> of obviously correct clean-up, not the other way around.
Me too. I just didn't want to make more work for Jacob (in having to
rebase on top of mine) or for you (in having to do a non-obvious merge a
few days from now).
-Peff
next prev parent reply other threads:[~2014-07-10 19:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 22:36 [PATCH v2] tag: support configuring --sort via .gitconfig Jacob Keller
2014-07-10 4:00 ` Jeff King
2014-07-10 4:07 ` Jeff King
2014-07-10 17:59 ` Junio C Hamano
2014-07-10 19:34 ` Jeff King [this message]
2014-07-10 21:50 ` Keller, Jacob E
2014-07-10 22:46 ` Junio C Hamano
2014-07-10 20:38 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710193404.GA15615@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.e.keller@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).