From: Jonathan Nieder <jrnieder@gmail.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] strbuf: use strbuf_addstr() for adding C strings
Date: Wed, 16 Jul 2014 16:41:51 -0700 [thread overview]
Message-ID: <20140716234151.GN12427@google.com> (raw)
In-Reply-To: <53C70CEA.8000000@web.de>
René Scharfe wrote:
> Avoid code duplication and let strbuf_addstr() call strlen() for us.
Nice.
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
> builtin/commit.c | 2 +-
> diff.c | 12 ++++++------
> path.c | 6 +++---
> 3 files changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
prev parent reply other threads:[~2014-07-16 23:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 23:38 [PATCH] strbuf: use strbuf_addstr() for adding C strings René Scharfe
2014-07-16 23:41 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140716234151.GN12427@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).