From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Michael Haggerty <mhagger@alum.mit.edu>,
Jakub Narebski <jnareb@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: [PATCH v7 0/9] Add --graft option to git replace
Date: Sat, 19 Jul 2014 17:01:06 +0200 [thread overview]
Message-ID: <20140719145951.9564.61331.chriscool@tuxfamily.org> (raw)
Here is a small series to implement:
git replace [-f] --graft <commit> [<parent>...]
This patch series goes on top of the patch series that
implements --edit.
The changes since v6, thanks to Junio, are:
- the patch that adds for_each_mergetag() is not part of the
series any more; it is managed by Junio in another dedicated
series
- replace_parents() iterates over all the argv it is passed,
not just from argv[1] to argv[argc - 1], in patch 2/9
- in t6050-replace.sh, commit_buffer_contains_parents() has
been simplified, in patch 3/9
- in t6050-replace.sh, there is now a space between function
names and (), in patch 3/9
- in t6050-replace.sh, there has been a refactoring regarding
how commit parenthood is tested, in patchs 3/9 and 7/9; we
only use commit_has_parents() that now tests everything
- in t6050-replace.sh, commit_buffer_contains_parents()
compares the 'expected' and 'actual' files in the right
order, in patch 3/9
We still error if the replacement commit that would be created
would be the same as the existing one, as we already do when
using --edit. If people care, I suggest they send a patch to
change both --graft and --edit at the same time.
Christian Couder (9):
replace: cleanup redirection style in tests
replace: add --graft option
replace: add test for --graft
Documentation: replace: add --graft option
contrib: add convert-grafts-to-replace-refs.sh
replace: remove signature when using --graft
replace: add test for --graft with signed commit
replace: check mergetags when using --graft
replace: add test for --graft with a mergetag
Documentation/git-replace.txt | 10 +++
builtin/replace.c | 126 ++++++++++++++++++++++++++-
commit.c | 34 ++++++++
commit.h | 2 +
contrib/convert-grafts-to-replace-refs.sh | 28 ++++++
t/t6050-replace.sh | 139 ++++++++++++++++++++++++------
6 files changed, 313 insertions(+), 26 deletions(-)
create mode 100755 contrib/convert-grafts-to-replace-refs.sh
--
2.0.0.421.g786a89d.dirty
next reply other threads:[~2014-07-19 15:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-19 15:01 Christian Couder [this message]
2014-07-19 15:01 ` [PATCH v7 1/9] replace: cleanup redirection style in tests Christian Couder
2014-07-19 15:01 ` [PATCH v7 2/9] replace: add --graft option Christian Couder
2014-07-19 15:01 ` [PATCH v7 3/9] replace: add test for --graft Christian Couder
2014-07-19 15:01 ` [PATCH v7 4/9] Documentation: replace: add --graft option Christian Couder
2014-07-19 15:01 ` [PATCH v7 5/9] contrib: add convert-grafts-to-replace-refs.sh Christian Couder
2014-07-19 15:01 ` [PATCH v7 6/9] replace: remove signature when using --graft Christian Couder
2014-07-19 15:01 ` [PATCH v7 7/9] replace: add test for --graft with signed commit Christian Couder
2014-07-19 15:01 ` [PATCH v7 8/9] replace: check mergetags when using --graft Christian Couder
2014-07-19 15:01 ` [PATCH v7 9/9] replace: add test for --graft with a mergetag Christian Couder
2014-07-21 20:09 ` [PATCH v7 0/9] Add --graft option to git replace Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140719145951.9564.61331.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).