From: Jonathan Nieder <jrnieder@gmail.com>
To: Ronnie Sahlberg <sahlberg@google.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 2/5] refs.c: return error instead of dying when locking fails during transaction
Date: Fri, 25 Jul 2014 12:40:23 -0700 [thread overview]
Message-ID: <20140725194023.GH12427@google.com> (raw)
In-Reply-To: <1406307521-10339-3-git-send-email-sahlberg@google.com>
Ronnie Sahlberg wrote:
> --- a/refs.c
> +++ b/refs.c
> @@ -2214,7 +2214,7 @@ static struct ref_lock *lock_ref_sha1_basic(const char *refname,
> */
> goto retry;
> else
> - unable_to_lock_index_die(ref_file, errno);
> + goto error_return;
Should probably save last_errno so error_return can pass that
information back.
Can the caller recover from this error? Does it have enough information
to produce the same helpful message as unable_to_lock_index_die?
If this could be done without regressing behavior (e.g., by passing
back error information as a message instead of through errno) then I
think it would make sense.
Jonathan
next prev parent reply other threads:[~2014-07-25 19:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 16:58 [PATCH 0/5] ref-transactions-rename Ronnie Sahlberg
2014-07-25 16:58 ` [PATCH 1/5] refs.c: allow passing raw git_committer_info as email to _update_reflog Ronnie Sahlberg
2014-07-25 19:37 ` Jonathan Nieder
2014-07-28 18:01 ` Ronnie Sahlberg
2014-07-28 23:39 ` Eric Sunshine
2014-07-25 16:58 ` [PATCH 2/5] refs.c: return error instead of dying when locking fails during transaction Ronnie Sahlberg
2014-07-25 19:40 ` Jonathan Nieder [this message]
2014-07-28 19:01 ` Ronnie Sahlberg
2014-07-25 16:58 ` [PATCH 3/5] refs.c: use packed refs when deleting refs during a transaction Ronnie Sahlberg
2014-07-25 19:58 ` Jonathan Nieder
2014-07-25 16:58 ` [PATCH 4/5] refs.c: update rename_ref to use " Ronnie Sahlberg
2014-07-25 20:00 ` Jonathan Nieder
2014-07-25 16:58 ` [PATCH 5/5] refs.c: rollback the lockfile before we die() in repack_without_refs Ronnie Sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140725194023.GH12427@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sahlberg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).