From: Jonathan Nieder <jrnieder@gmail.com>
To: "Besen, David" <david.besen@hp.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Amending merge commits?
Date: Fri, 25 Jul 2014 15:19:11 -0700 [thread overview]
Message-ID: <20140725221911.GL12427@google.com> (raw)
In-Reply-To: <22F01493C523F940B4B5E53BB6D0F5352275F207@G5W2738.americas.hpqcorp.net>
Besen, David wrote:
> I think one of my coworkers has stumbled on a git bug -- if you
> amend a merge commit, and then pull, your amends are lost.
This is how pull --rebase works. It turns your single-parent commits
into a sequence of patches on top of upstream and completely ignores
your merge commits.
There is a --rebase=preserve option that makes a halfhearted attempt
to preserve your merges --- perhaps that would help? The
git-rebase(1) documentation has more details.
In an ideal world, I think pull --rebase would do the following:
1. Do the same thing it does today
2. Behind the scenes, *also* try a 'pull --merge' but don't save
the result.
3. Compare the results. If they differ, show a diff and explain
to the user what happened.
I may be the only one that wants that, though.
Hope that helps,
Jonathan
next prev parent reply other threads:[~2014-07-25 22:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 22:03 Amending merge commits? Besen, David
2014-07-25 22:11 ` David Besen
2014-07-25 22:19 ` Jonathan Nieder [this message]
2014-07-25 22:23 ` Besen, David
2014-07-25 22:31 ` Jonathan Nieder
2014-07-28 19:37 ` Sergei Organov
2014-07-28 20:00 ` Jonathan Nieder
2014-07-28 20:53 ` Sergei Organov
-- strict thread matches above, loose matches on Subject: below --
2014-07-28 21:47 Nico Williams
2014-07-29 9:58 ` Sergei Organov
2014-07-29 15:44 ` Nico Williams
2014-07-29 19:29 ` Philip Oakley
2014-07-29 20:19 ` Nico Williams
2014-07-29 21:38 ` Philip Oakley
2014-07-29 22:07 ` Nico Williams
2014-07-30 8:42 ` Sergei Organov
2014-07-30 17:43 ` Nico Williams
2014-07-30 18:28 ` Sergei Organov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140725221911.GL12427@google.com \
--to=jrnieder@gmail.com \
--cc=david.besen@hp.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).