From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] Documentation: avoid dangling modifier for imap-send
Date: Tue, 5 Aug 2014 00:54:51 +0000 [thread overview]
Message-ID: <20140805005451.GA10435@vauxhall.crustytoothpaste.net> (raw)
In-Reply-To: <xmqq8un4rtv6.fsf@gitster.dls.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]
On Mon, Aug 04, 2014 at 11:29:33AM -0700, Junio C Hamano wrote:
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
> > Avoid a nonsensical misreading by moving the modifier closer to the
> > word it modifies.
> >
> > Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> > ---
> > Documentation/git-imap-send.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt
> > index 875d283..23231e1 100644
> > --- a/Documentation/git-imap-send.txt
> > +++ b/Documentation/git-imap-send.txt
> > @@ -43,7 +43,7 @@ imap.folder::
> > imap.tunnel::
> > Command used to setup a tunnel to the IMAP server through which
> > commands will be piped instead of using a direct network connection
> > - to the server. Required when imap.host is not set to use imap-send.
> > + to the server. Required to use imap-send when imap.host is not set.
>
> To be honest, I find both versions are equally confusing.
>
> How about dropping the three words "to use imap-send"?
Fine by me.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-05 0:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 23:57 [PATCH] Documentation: avoid dangling modifier for imap-send brian m. carlson
2014-08-03 0:14 ` [PATCH v2] " brian m. carlson
2014-08-04 18:29 ` Junio C Hamano
2014-08-05 0:54 ` brian m. carlson [this message]
2014-08-05 1:13 ` brian m. carlson
2014-08-05 2:45 ` Jonathan Nieder
2014-08-05 2:51 ` Jonathan Nieder
2014-08-05 2:52 ` brian m. carlson
2014-08-05 2:57 ` Jonathan Nieder
2014-08-05 2:56 ` [PATCH v3] imap-send doc: omit confusing "to use imap-send" modifier brian m. carlson
2014-08-05 20:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140805005451.GA10435@vauxhall.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).