From: Linus Arver <linusarver@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/7] Documentation: git-init: template directory: reword
Date: Fri, 8 Aug 2014 09:36:54 -0700 [thread overview]
Message-ID: <20140808163652.GA791@k0> (raw)
In-Reply-To: <xmqqwqalmt42.fsf@gitster.dls.corp.google.com>
On Wed, Aug 06, 2014 at 10:21:33AM -0700, Junio C Hamano wrote:
> Linus Arver <linusarver@gmail.com> writes:
>
> > No, the unindenting/removal of blank lines is a non-grammar change and
> > is not necessary, as it doesn't have any effect on the actual output
> > (html/txt/manpage).
> >
> > I can either keep the same coding style with the rewording, or chop this
> > into two commits, one for the rewording and another for reformatting.
> > Which one do you suggest?
>
> If I were doing this change, I wouldn't touch the formatting,
> because I did not find that the reformatted version would be any
> easier to read or maintain compared to the original.
>
> But I suspect that you must have thought the reformatting was a good
> thing to do for a reason, and I suspected I might have been missing
> something obvious to you, and that was why I asked. If there is a
> good reason to reformat, then lets hear it in the commit log message
> of one of the two patches. Otherwise we can drop the reformatting
> part.
And well, considering that the rewording makes the separate items into a
single sentence, I thought it would help readability to delete all the
whitespace.
In retrospect, I don't think this is a good enough reason to reformat.
It was more of a personal writing style judgment call. I am dropping the
reformatting part.
next prev parent reply other threads:[~2014-08-08 16:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 18:06 [PATCH] lots of documentation fixes/rewordings in git-init(1) Linus Arver
2014-08-02 18:06 ` [PATCH 1/7] Documentation: git-init: typographical fixes Linus Arver
2014-08-05 22:06 ` Junio C Hamano
2014-08-06 4:58 ` Linus Arver
2014-08-02 18:06 ` [PATCH 2/7] Documentation: git-init: list items facelift Linus Arver
2014-08-02 18:06 ` [PATCH 3/7] Documentation: git-init: template directory: reword Linus Arver
2014-08-05 22:10 ` Junio C Hamano
2014-08-06 5:15 ` Linus Arver
2014-08-06 17:21 ` Junio C Hamano
2014-08-08 16:36 ` Linus Arver [this message]
2014-08-02 18:06 ` [PATCH 4/7] Documentation: git-init: --separate-git-dir: clarify Linus Arver
2014-08-05 22:12 ` Junio C Hamano
2014-08-06 5:21 ` Linus Arver
2014-08-06 17:35 ` Junio C Hamano
2014-08-08 16:42 ` Linus Arver
2014-08-02 18:06 ` [PATCH 5/7] Documentation: git-init: reword parenthetical statements Linus Arver
2014-08-02 18:06 ` [PATCH 6/7] Documentation: git-init: template directory: reword and cross-reference Linus Arver
2014-08-02 18:06 ` [PATCH 7/7] Documentation: git-init: flesh out example Linus Arver
2014-08-05 22:14 ` Junio C Hamano
2014-08-06 5:34 ` Linus Arver
2014-08-06 17:41 ` Junio C Hamano
2014-08-08 16:49 ` Linus Arver
2014-08-08 17:29 ` [PATCH v2] lots of documentation fixes/rewordings in git-init(1) Linus Arver
2014-08-08 17:29 ` [PATCH v2 1/7] Documentation: git-init: typographical fixes Linus Arver
2014-08-08 17:29 ` [PATCH v2 2/7] Documentation: git-init: list items facelift Linus Arver
2014-08-08 17:29 ` [PATCH v2 3/7] Documentation: git-init: template directory: reword Linus Arver
2014-08-08 17:29 ` [PATCH v2 4/7] Documentation: git-init: --separate-git-dir: clarify Linus Arver
2014-08-08 17:29 ` [PATCH v2 5/7] Documentation: git-init: reword parenthetical statements Linus Arver
2014-08-08 17:29 ` [PATCH v2 6/7] Documentation: git-init: template directory: reword and cross-reference Linus Arver
2014-08-08 17:29 ` [PATCH v2 7/7] Documentation: git-init: flesh out example Linus Arver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140808163652.GA791@k0 \
--to=linusarver@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).