From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
LKML <linux-kernel@vger.kernel.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: Add test for commit id formatting style in commit log
Date: Sun, 10 Aug 2014 14:35:00 -0700 [thread overview]
Message-ID: <20140810143500.2d556ae9.akpm@linux-foundation.org> (raw)
In-Reply-To: <1407706081.4082.21.camel@joe-AO725>
On Sun, 10 Aug 2014 14:28:01 -0700 Joe Perches <joe@perches.com> wrote:
> > On Thu, Jul 3, 2014 at 12:00 AM, Joe Perches <joe@perches.com> wrote:
> > > Commit logs have various forms of commit id references.
> > >
> > > Try to standardize on a 12 character long lower case
> > > commit id along with a description of parentheses and
> > > the quoted subject line
> > >
> > > ie: commit 0123456789ab ("commit description")
> >
> > Now this is in mainline, checkpatch starts complaining about my "too long"
> > (40 chars) commit IDs in commit messages :-(
> >
> > 40 chars may be too long (but it's quick to copy-and-paste, as "git show"
> > shows that by default), but 12 sounds a bit short, as that's only 48 bits.
>
> Right now, this test allows 12 to 16 byte length commit ids
> without emitting a warning.
>
> Andrew wanted this test, I don't care how long the commit id
> is in the commit log.
Well, I mainly wanted to stop having to add "commit description" when
people forget it. The length check was perhaps a bit anal. How about
we make it "12 or more"?
next prev parent reply other threads:[~2014-08-10 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140702130210.fd40d67f0819cfb5f3e9e5ca@linux-foundation.org>
[not found] ` <1404331746.14624.95.camel@joe-AO725>
[not found] ` <20140702131534.c613f55f79519b3862f79e40@linux-foundation.org>
[not found] ` <1404338448.14741.8.camel@joe-AO725>
2014-08-10 21:08 ` [PATCH] checkpatch: Add test for commit id formatting style in commit log Geert Uytterhoeven
2014-08-10 21:28 ` Joe Perches
2014-08-10 21:35 ` Andrew Morton [this message]
2014-08-10 21:41 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140810143500.2d556ae9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=git@vger.kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).