From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Steffen Prohaska <prohaska@zib.de>,
John Keeping <john@keeping.me.uk>,
Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>,
Scott Chacon <schacon@gmail.com>
Subject: Re: [PATCH v2 2/2] convert: Stream from fd to required clean filter instead of mmap
Date: Tue, 19 Aug 2014 03:53:45 -0400 [thread overview]
Message-ID: <20140819075345.GA7712@peff.net> (raw)
In-Reply-To: <CACsJy8BUBfQeny4iu6nZ+pCy84_=8EEfEHY3pWLpx_1PLCwC5w@mail.gmail.com>
On Sun, Aug 17, 2014 at 06:33:54PM +0700, Duy Nguyen wrote:
> > For files >2GB on a 32-bit system (e.g. msysgit), filtering with the
> > previous code always failed. Now it works. I created the patch to
> > change git from 'fundamentally doesn't handle this' to 'works as
> > expected'.
>
> I deal with similar problem and added $GIT_ALLOC_LIMIT to test large
> blob code. Maybe we could add $GIT_MMAP_LIMIT? I don't suppose we call
> xmmap/xmalloc so often that the extra test would slow git down.
Yeah, I think I'd prefer that approach. We should mmap _way_ less than
we malloc, and I do not think the malloc check has caused any problems.
-Peff
next prev parent reply other threads:[~2014-08-19 7:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 5:32 [PATCH v2 0/2] Stream fd to clean filter Steffen Prohaska
2014-08-06 5:32 ` [PATCH v2 1/2] convert: Refactor would_convert_to_git() to single arg 'path' Steffen Prohaska
2014-08-06 5:32 ` [PATCH v2 2/2] convert: Stream from fd to required clean filter instead of mmap Steffen Prohaska
2014-08-16 10:27 ` John Keeping
2014-08-16 16:26 ` Steffen Prohaska
2014-08-16 17:00 ` Andreas Schwab
2014-08-17 10:08 ` Steffen Prohaska
2014-08-17 11:03 ` Andreas Schwab
2014-08-17 7:27 ` Jeff King
2014-08-17 10:25 ` Steffen Prohaska
2014-08-17 11:33 ` Duy Nguyen
2014-08-19 7:53 ` Jeff King [this message]
2014-08-19 8:26 ` Steffen Prohaska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819075345.GA7712@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=pclouds@gmail.com \
--cc=prohaska@zib.de \
--cc=schacon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).