From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH 1/2] Makefile: use "find" to determine static header dependencies Date: Fri, 22 Aug 2014 00:12:36 -0400 Message-ID: <20140822041236.GC27992@peff.net> References: <20140821082440.GA16402@peff.net> <20140821082935.GA25763@peff.net> <20140821144818.GG20185@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: git@vger.kernel.org, Jiang Xin To: Jonathan Nieder X-From: git-owner@vger.kernel.org Fri Aug 22 06:12:48 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XKgDS-0008I9-0s for gcvg-git-2@plane.gmane.org; Fri, 22 Aug 2014 06:12:42 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751384AbaHVEMi (ORCPT ); Fri, 22 Aug 2014 00:12:38 -0400 Received: from cloud.peff.net ([50.56.180.127]:56569 "HELO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751314AbaHVEMi (ORCPT ); Fri, 22 Aug 2014 00:12:38 -0400 Received: (qmail 879 invoked by uid 102); 22 Aug 2014 04:12:38 -0000 Received: from c-71-63-4-13.hsd1.va.comcast.net (HELO sigill.intra.peff.net) (71.63.4.13) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.84) with ESMTPA; Thu, 21 Aug 2014 23:12:38 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 22 Aug 2014 00:12:36 -0400 Content-Disposition: inline In-Reply-To: <20140821144818.GG20185@google.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Thu, Aug 21, 2014 at 07:48:18AM -0700, Jonathan Nieder wrote: > Subject: i18n: treat "make pot" as an explicitly-invoked target > > po/git.pot is normally used as-is and not regenerated by people > building git, so it is okay if an explicit "make po/git.pot" always > automatically regenerates it. Depend on the magic FORCE target > instead of explicitly keeping track of dependencies. > > This simplifies the makefile, in particular preparing for a moment > when $(LIB_H), which is part of $(LOCALIZED_C), can be computed on the > fly. > > We still need a dependency on GENERATED_H, to force those files to be > built when regenerating git.pot. > > Signed-off-by: Jonathan Nieder Yeah, this is way less gross than what I proposed, and I do not think it hurts anything. We do still need to drop the use of ":=" in assigning LOCALIZED_C, but I do not think there is any need for it in the first place. -Peff