From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: [PATCH v2 0/3] dropping manually-maintained LIB_H Date: Fri, 22 Aug 2014 00:27:16 -0400 Message-ID: <20140822042716.GE27992@peff.net> References: <20140821082440.GA16402@peff.net> <20140821082935.GA25763@peff.net> <20140821144818.GG20185@google.com> <20140822041236.GC27992@peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: git@vger.kernel.org, Jiang Xin To: Jonathan Nieder X-From: git-owner@vger.kernel.org Fri Aug 22 06:27:30 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XKgRe-0008Rx-Un for gcvg-git-2@plane.gmane.org; Fri, 22 Aug 2014 06:27:23 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752355AbaHVE1T (ORCPT ); Fri, 22 Aug 2014 00:27:19 -0400 Received: from cloud.peff.net ([50.56.180.127]:56580 "HELO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751232AbaHVE1S (ORCPT ); Fri, 22 Aug 2014 00:27:18 -0400 Received: (qmail 1587 invoked by uid 102); 22 Aug 2014 04:27:18 -0000 Received: from c-71-63-4-13.hsd1.va.comcast.net (HELO sigill.intra.peff.net) (71.63.4.13) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.84) with ESMTPA; Thu, 21 Aug 2014 23:27:18 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 22 Aug 2014 00:27:16 -0400 Content-Disposition: inline In-Reply-To: <20140822041236.GC27992@peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Fri, Aug 22, 2014 at 12:12:36AM -0400, Jeff King wrote: > > po/git.pot is normally used as-is and not regenerated by people > > building git, so it is okay if an explicit "make po/git.pot" always > > automatically regenerates it. Depend on the magic FORCE target > > instead of explicitly keeping track of dependencies. > > Yeah, this is way less gross than what I proposed, and I do not think it > hurts anything. We do still need to drop the use of ":=" in assigning > LOCALIZED_C, but I do not think there is any need for it in the first > place. Here's a re-roll of my series on top of your patch. In addition to rebasing, I also switched it to use $(FIND) in the shell snippet rather than a bare "find". I notice that for the ctags generation we actually try "git ls-tree" first and then fall back to "find". I guess we could do that here, but I do not think the speed improvement matters much. And I think the "find" output is a little more conservative. If you are adding a new header file but have not mentioned it to git yet, I think we would prefer to err on the side of including it as a potential dependency. [1/3]: i18n: treat "make pot" as an explicitly-invoked target [2/3]: Makefile: use `find` to determine static header dependencies [3/3]: Makefile: drop CHECK_HEADER_DEPENDENCIES code -Peff