git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Philippe Vaucher" <philippe.vaucher@gmail.com>,
	"Rémy Hubscher" <hubscher.remy@gmail.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Improving the git remote command
Date: Tue, 26 Aug 2014 13:33:12 -0400	[thread overview]
Message-ID: <20140826173312.GB16394@peff.net> (raw)
In-Reply-To: <xmqq7g1vjh9o.fsf@gitster.dls.corp.google.com>

On Tue, Aug 26, 2014 at 10:24:35AM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > ... But we are left with three options:
> >
> >   1. Add "git remote list" with verbose output. This is bad because it
> >      differs gratuitously from "git remote".
> >
> >   2. Add "git remote list" with non-verbose output. This is good because
> >      it means "git remote" is just a shortcut for "git remote list",
> >      which is consistent with other parts of git. But it is potentially
> >      bad if "-v" is a better output format.
> >
> >   3. Add "git remote list" with verbose output, and tweak "git remote"
> >      to match. This is bad because it breaks backwards compatibility.
> >
> > The proposal is for (1). I think we agree that (3) is out. The question
> > is whether (1) or (2) is the least bad.
> 
> I would imagine that those who want list of remotes programatically
> would read from "git config" output and it would be with less
> friction to change the output from "git remote", a command that is
> solely to cater to end-user humans, to suit people's needs, so I am
> not sure if (3) is immediately "out".

Yeah, I touched on that earlier. I would personally consider "git
remote" to be a porcelain, and "git config" to be the appropriate
plumbing for accessing those values. However, it's a little tricky to
robustly get the list of remotes with "git config". So I would not be
surprised if scripts have used "git remote" to do the same thing (I know
for a fact that some internal scripts at GitHub did this, though I
recently cleaned them up so I do not have a vested interest either way
at this point).

That does not mean those scripts are right and we cannot change things,
but it may be a matter of practicality.

> Having said that, my preference is 
> 
>     0. Do nothing, but document the "default to listing" better if
>        needed.
> 
> and then 2. above, and then 1.

Yeah, I'd agree with that.

-Peff

  reply	other threads:[~2014-08-26 17:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26  9:29 Improving the git remote command Rémy Hubscher
2014-08-26 10:05 ` Philippe Vaucher
2014-08-26 12:40 ` Jeff King
2014-08-26 16:19   ` Philippe Vaucher
2014-08-26 16:37     ` Jeff King
2014-08-26 17:24       ` Junio C Hamano
2014-08-26 17:33         ` Jeff King [this message]
2014-08-27 16:36           ` David Aguilar
2014-08-27 20:35             ` Junio C Hamano
2014-08-27 21:22               ` Keller, Jacob E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140826173312.GB16394@peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hubscher.remy@gmail.com \
    --cc=philippe.vaucher@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).