From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Steffen Prohaska <prohaska@zib.de>,
git@vger.kernel.org, pclouds@gmail.com, john@keeping.me.uk,
schacon@gmail.com
Subject: Re: [PATCH v6 2/6] Add git_env_ulong() to parse environment variable
Date: Tue, 26 Aug 2014 16:31:59 -0400 [thread overview]
Message-ID: <20140826203158.GA30651@peff.net> (raw)
In-Reply-To: <xmqq38cjhuje.fsf@gitster.dls.corp.google.com>
On Tue, Aug 26, 2014 at 01:20:53PM -0700, Junio C Hamano wrote:
> I think different people have different confusion criteria.
> To me, these two are very different operations:
>
> $ VAR=
> $ unset VAR
>
> I think it boils down to that I see that the distance between "unset
> vs set to empty" is far larger than the distance between "empty vs
> false". You probably see these two distances the other way,
> i.e. "set to empty is almost like unset" and "empty is not a valid
> way to say false".
>
> Due to this difference, the new test confused me and had me read it
> three times.
I agree that it is rather a subjective decision.
> So, I am not sure the patch in the message I am responding to, and I
> am not sure about that *v check in Steffen's patch, either.
If it is truly "some people prefer it one way and some the other", I am
not sure if we should leave it as-is (that is preferring one way). The
middle ground would be to die(). That does not seem super-friendly, but
then we would also die with GIT_SMART_HTTP=foobar, so perhaps it is not
unreasonable to just consider it a syntax error.
I dunno. I can live with leaving it as-is. Certainly the existing
behavior is not what I expected, but it is not like it came up in the
real world (and I would not expect it to do so often). And it is
consistent with the config, which treats:
[foo]
bar =
as boolean false. That _also_ seems weird to me, but that is not
something I think we can easily change or outlaw at this point anyway.
-Peff
next prev parent reply other threads:[~2014-08-26 20:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 15:23 [PATCH v6 0/6] Stream fd to clean filter; GIT_MMAP_LIMIT, GIT_ALLOC_LIMIT with git_env_ulong() Steffen Prohaska
2014-08-26 15:23 ` [PATCH v6 1/6] convert: drop arguments other than 'path' from would_convert_to_git() Steffen Prohaska
2014-08-26 15:23 ` [PATCH v6 2/6] Add git_env_ulong() to parse environment variable Steffen Prohaska
2014-08-26 18:21 ` Jeff King
2014-08-26 20:20 ` Junio C Hamano
2014-08-26 20:31 ` Jeff King [this message]
2014-08-26 21:54 ` Junio C Hamano
2014-08-27 4:46 ` Jeff King
2014-08-27 14:47 ` Junio C Hamano
2014-08-28 15:21 ` Steffen Prohaska
2014-08-28 17:13 ` Junio C Hamano
2014-08-26 15:23 ` [PATCH v6 3/6] Change GIT_ALLOC_LIMIT check to use git_env_ulong() Steffen Prohaska
2014-08-26 15:23 ` [PATCH v6 4/6] Introduce GIT_MMAP_LIMIT to allow testing expected mmap size Steffen Prohaska
2014-08-26 15:23 ` [PATCH v6 5/6] Change copy_fd() to not close input fd Steffen Prohaska
2014-08-26 17:10 ` Junio C Hamano
2014-08-26 18:29 ` Jeff King
2014-08-28 15:37 ` Steffen Prohaska
2014-08-28 17:15 ` Junio C Hamano
2014-08-26 15:23 ` [PATCH v6 6/6] convert: stream from fd to required clean filter to reduce used address space Steffen Prohaska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826203158.GA30651@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=pclouds@gmail.com \
--cc=prohaska@zib.de \
--cc=schacon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).