From: Max Kirillov <max@max630.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Git List" <git@vger.kernel.org>
Subject: Re: [PATCH] setup.c: set workdir when gitdir is not default
Date: Thu, 4 Sep 2014 17:23:22 +0300 [thread overview]
Message-ID: <20140904142322.GB8894@wheezy.local> (raw)
In-Reply-To: <CAPig+cQMNyurCB73CzGBLcfXqap5=kZsYq0O8nD29S8QsHtrBA@mail.gmail.com>
On Thu, Sep 04, 2014 at 06:44:08AM -0400, Eric Sunshine wrote:
> > + mkdir -p subdir &&
> > + cd subdir &&
> > + git testalias
>
> If a new test is added following this one, it will be run from within
> 'subdir', which might come as a surprise as the author of the new
> test. Wrapping the 'cd' and following code in a subshell is a good way
> to avoid the problem.
Sure, my mistake. Will fix this and the other issue you
mentioned. Thank you.
--
Max
next prev parent reply other threads:[~2014-09-04 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 22:42 [PATCH] setup.c: set workdir when gitdir is not default Max Kirillov
2014-09-04 10:44 ` Eric Sunshine
2014-09-04 14:23 ` Max Kirillov [this message]
2014-09-04 10:53 ` Duy Nguyen
2014-09-04 14:20 ` Max Kirillov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904142322.GB8894@wheezy.local \
--to=max@max630.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).