From mboxrd@z Thu Jan 1 00:00:00 1970 From: Max Kirillov Subject: Re: [PATCH] setup.c: set workdir when gitdir is not default Date: Thu, 4 Sep 2014 17:23:22 +0300 Message-ID: <20140904142322.GB8894@wheezy.local> References: <1409784120-2228-1-git-send-email-max@max630.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Junio C Hamano , =?utf-8?B?Tmd1eeG7hW4gVGjDoWkgTmfhu41j?= Duy , Jonathan Nieder , Git List To: Eric Sunshine X-From: git-owner@vger.kernel.org Thu Sep 04 16:24:04 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XPXx9-0005DX-RA for gcvg-git-2@plane.gmane.org; Thu, 04 Sep 2014 16:24:00 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750882AbaIDOXz (ORCPT ); Thu, 4 Sep 2014 10:23:55 -0400 Received: from p3plsmtpa12-06.prod.phx3.secureserver.net ([68.178.252.235]:40938 "EHLO p3plsmtpa12-06.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750723AbaIDOXz (ORCPT ); Thu, 4 Sep 2014 10:23:55 -0400 Received: from wheezy.local ([82.181.158.170]) by p3plsmtpa12-06.prod.phx3.secureserver.net with id n2Pp1o00N3gsSd6012PsPl; Thu, 04 Sep 2014 07:23:54 -0700 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Thu, Sep 04, 2014 at 06:44:08AM -0400, Eric Sunshine wrote: > > + mkdir -p subdir && > > + cd subdir && > > + git testalias > > If a new test is added following this one, it will be run from within > 'subdir', which might come as a surprise as the author of the new > test. Wrapping the 'cd' and following code in a subshell is a good way > to avoid the problem. Sure, my mistake. Will fix this and the other issue you mentioned. Thank you. -- Max