From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ronnie Sahlberg <sahlberg@google.com>,
git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: [PATCH v2] refs: speed up is_refname_available
Date: Wed, 10 Sep 2014 21:39:03 -0400 [thread overview]
Message-ID: <20140911013903.GA5525@peff.net> (raw)
In-Reply-To: <xmqqk35bf764.fsf@gitster.dls.corp.google.com>
On Wed, Sep 10, 2014 at 03:21:39PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > ...
> > Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
> > Signed-off-by: Jeff King <peff@peff.net>
> > ---
> > Sorry for the quick v2; Michael and I crossed emails off-list, and I
> > missed some of his review. This version has some minor style and comment
> > fixups.
>
> Looks sensible from a cursory read, but it conflicts heavily with
> 54e696fc (refs.c: pass a skip list to name_conflict_fn, 2014-07-16)
> which is queued early on 'pu', and I am definitely not in the
> business of re-designing that huge topic myself.
Did you miss the part in v1 where I pointed to a tree with a proposed
resolution? :)
I am also happy to rebase if the other bits are coming to master soon.
-Peff
next prev parent reply other threads:[~2014-09-11 1:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 10:17 [PATCH] refs: speed up is_refname_available Jeff King
2014-09-10 11:11 ` [PATCH v2] " Jeff King
2014-09-10 22:21 ` Junio C Hamano
2014-09-11 1:39 ` Jeff King [this message]
2014-09-10 22:22 ` Junio C Hamano
2014-09-11 17:07 ` [PATCH] " Junio C Hamano
2014-09-11 18:31 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911013903.GA5525@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=sahlberg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).