From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git Mailing List <git@vger.kernel.org>,
Stefan Beller <stefanbeller@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 1/3] prune-packed: fix minor memory leak
Date: Sat, 13 Sep 2014 16:16:53 -0400 [thread overview]
Message-ID: <20140913201653.GA27082@peff.net> (raw)
In-Reply-To: <20140913201538.GA24854@peff.net>
We form all of our directories in a strbuf, but never release it.
Signed-off-by: Jeff King <peff@peff.net>
---
builtin/prune-packed.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/builtin/prune-packed.c b/builtin/prune-packed.c
index 6879468..d430731 100644
--- a/builtin/prune-packed.c
+++ b/builtin/prune-packed.c
@@ -68,6 +68,7 @@ void prune_packed_objects(int opts)
rmdir(pathname.buf);
}
stop_progress(&progress);
+ strbuf_release(&pathname);
}
int cmd_prune_packed(int argc, const char **argv, const char *prefix)
--
2.1.0.373.g91ca799
next prev parent reply other threads:[~2014-09-13 20:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 7:28 [PATCH] repack: call prune_packed_objects() and update_server_info() directly René Scharfe
2014-09-13 8:59 ` Stefan Beller
2014-09-13 20:15 ` Jeff King
2014-09-13 20:16 ` Jeff King [this message]
2014-09-13 20:19 ` [PATCH 2/3] make update-server-info more robust Jeff King
2014-09-14 17:38 ` René Scharfe
2014-09-15 18:39 ` Junio C Hamano
2014-09-15 23:56 ` Jeff King
2014-09-13 20:19 ` [PATCH 3/3] server-info: clean up after writing info/packs Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140913201653.GA27082@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=stefanbeller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).