From: David Aguilar <davvid@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Fabian Ruch <bafain@gmail.com>
Subject: Re: [PATCH v3 1/3] t1503: test rev-parse --verify --quiet with deleted reflogs
Date: Mon, 15 Sep 2014 20:06:17 -0700 [thread overview]
Message-ID: <20140916030615.GA2286@gmail.com> (raw)
In-Reply-To: <xmqqk3544ire.fsf@gitster.dls.corp.google.com>
On Mon, Sep 15, 2014 at 03:32:37PM -0700, Junio C Hamano wrote:
> David Aguilar <davvid@gmail.com> writes:
>
> > Ensure that rev-parse --verify --quiet is silent when asked
> > about deleted reflog entries.
> >
> > Helped-by: Fabian Ruch <bafain@gmail.com>
> > Signed-off-by: David Aguilar <davvid@gmail.com>
> > ---
> > Differences since last time:
> >
> > This goes back to the original approach of using "git update-ref"
> > plumbing instead of "git branch" when testing deleted reflogs.
>
> Is this 1/3 (the first one in the series) supposed to pass without
> no other patches, either in the series or something outside?
>
It depends on the patch I sent not too long ago that makes
rev-parse --quiet actually quiet.
I'll rework this series to do the test_must_be_empty cleanup
first and include the prerequisite patch when I re-roll shortly.
--
David
prev parent reply other threads:[~2014-09-16 3:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 19:07 [PATCH v3 1/3] t1503: test rev-parse --verify --quiet with deleted reflogs David Aguilar
2014-09-15 19:07 ` [PATCH v3 2/3] t1503: use test_must_be_empty David Aguilar
2014-09-15 19:07 ` [PATCH v3 3/3] Documentation: a note about stdout for git rev-parse --verify --quiet David Aguilar
2014-09-15 22:34 ` Junio C Hamano
2014-09-15 22:33 ` [PATCH v3 2/3] t1503: use test_must_be_empty Junio C Hamano
2014-09-15 22:32 ` [PATCH v3 1/3] t1503: test rev-parse --verify --quiet with deleted reflogs Junio C Hamano
2014-09-16 3:06 ` David Aguilar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916030615.GA2286@gmail.com \
--to=davvid@gmail.com \
--cc=bafain@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).