From: Jeff King <peff@peff.net>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Stepan Kasal <kasal@ucw.cz>, Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org,
Jean-Jacques Lafay <jeanjacques.lafay@gmail.com>
Subject: Re: [PATCH v3] git tag --contains: avoid stack overflow
Date: Tue, 23 Sep 2014 12:05:52 -0400 [thread overview]
Message-ID: <20140923160552.GA20624@peff.net> (raw)
In-Reply-To: <871tr688a4.fsf@igel.home>
On Sat, Sep 20, 2014 at 08:18:59PM +0200, Andreas Schwab wrote:
> Stepan Kasal <kasal@ucw.cz> writes:
>
> > diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
> > index 143a8ea..a911df0 100755
> > --- a/t/t7004-tag.sh
> > +++ b/t/t7004-tag.sh
> > @@ -1423,4 +1423,30 @@ EOF
> > test_cmp expect actual
> > '
> >
> > +run_with_limited_stack () {
> > + (ulimit -s 64 && "$@")
> > +}
>
> That is way too small.
>
> https://build.opensuse.org/package/live_build_log/openSUSE:Factory:PowerPC/git/standard/ppc64le
Thanks for the report. I'd be OK with just giving up and dropping this
test as too flaky and system-specific to be worth the trouble.
But if we do want to keep it, does bumping it to 128 (and bumping the
4000 to 8000 in the test below it) work?
-Peff
next prev parent reply other threads:[~2014-09-23 16:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 14:15 [PATCH] git tag --contains : avoid stack overflow Stepan Kasal
2014-04-16 15:46 ` Jeff King
2014-04-17 17:31 ` Johannes Schindelin
2014-04-17 21:32 ` Jeff King
2014-04-17 21:52 ` Johannes Schindelin
2014-04-17 21:58 ` Jeff King
2014-04-23 7:53 ` [PATCH v2] " Stepan Kasal
2014-04-23 14:28 ` Johannes Schindelin
2014-04-23 15:45 ` Stepan Kasal
2014-04-23 19:12 ` Junio C Hamano
2014-04-23 19:16 ` Jeff King
2014-04-23 20:48 ` Junio C Hamano
2014-04-23 20:55 ` Jeff King
2014-04-23 21:05 ` Junio C Hamano
2014-04-24 12:20 ` Stepan Kasal
2014-04-24 12:24 ` [PATCH v3] git tag --contains: " Stepan Kasal
2014-04-25 5:54 ` Jeff King
2014-09-20 18:18 ` Andreas Schwab
2014-09-23 16:05 ` Jeff King [this message]
2014-09-23 21:48 ` Andreas Schwab
2014-09-23 22:41 ` Junio C Hamano
2014-04-23 19:59 ` [PATCH v2] git tag --contains : " Stepan Kasal
2014-04-23 19:17 ` Jeff King
2014-04-23 21:14 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923160552.GA20624@peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeanjacques.lafay@gmail.com \
--cc=kasal@ucw.cz \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).