From: Edward Thomson <ethomson@edwardthomson.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Kirill Smelkov <kirr@mns.spb.ru>
Subject: Re: [RFC/PATCH] fsck: do not canonicalize modes in trees we are checking
Date: Tue, 23 Sep 2014 16:23:43 +0000 [thread overview]
Message-ID: <20140923162343.GA20379@debian> (raw)
In-Reply-To: <20140923154751.GA19319@peff.net>
On Tue, Sep 23, 2014 at 11:47:51AM -0400, Jeff King wrote:
> As far as I can tell, fsck's mode-checking has been totally broken
> basically forever. Which makes me a little nervous to fix it. :)
> linux.git does have some bogus modes, but they are 100664, which is
> specifically ignored here unless "fsck --strict" is in effect.
I'm in favor of checking the mode in fsck, at least when --strict.
But I would suggest we be lax (by default) about other likely-to-exist
but strictly invalid modes to prevent peoples previously workable
repositories from being now broken.
I have, for example, encountered 100775 in the wild, and would argue that
like 100644, it should probably not fail unless we are in --strict mode.
Thanks-
-ed
next prev parent reply other threads:[~2014-09-23 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 15:47 [RFC/PATCH] fsck: do not canonicalize modes in trees we are checking Jeff King
2014-09-23 16:23 ` Edward Thomson [this message]
2014-09-23 16:30 ` Jeff King
2014-10-12 22:37 ` Ben Aveling
2014-10-14 8:21 ` Jeff King
[not found] ` <543F074B.2050907@optusnet.com.au>
2014-10-16 0:20 ` Jeff King
2014-10-19 12:40 ` Ben Aveling
2014-10-20 9:21 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923162343.GA20379@debian \
--to=ethomson@edwardthomson.com \
--cc=git@vger.kernel.org \
--cc=kirr@mns.spb.ru \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).