From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Christian Couder <chriscool@tuxfamily.org>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v2 1/2] sha1-array: add test-sha1-array and basic tests
Date: Wed, 1 Oct 2014 11:19:10 -0400 [thread overview]
Message-ID: <20141001151910.GA20735@peff.net> (raw)
In-Reply-To: <542C1711.6080609@web.de>
On Wed, Oct 01, 2014 at 05:00:33PM +0200, René Scharfe wrote:
> Helped-by: Jeff King <peff@peff.net>
> Helped-by: Eric Sunshine <sunshine@sunshineco.com>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
> Added a test for looking up a non-existing entry in an array that
> contains duplicates, as suggested by Jeff. Changed echo20() to add
> a space after the prefix as needed, as suggested by Eric.
Both patches look good to me.
-Peff
prev parent reply other threads:[~2014-10-01 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 15:00 [PATCH v2 1/2] sha1-array: add test-sha1-array and basic tests René Scharfe
2014-10-01 15:02 ` [PATCH v2 2/2] sha1-lookup: handle duplicates in sha1_pos() René Scharfe
2014-10-01 15:19 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001151910.GA20735@peff.net \
--to=peff@peff.net \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).