From: Jeff King <peff@peff.net>
To: Derek Moore <derek.p.moore@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: DOCBOOK2X_TEXI in Documentation/Makefile invalid on some distributions
Date: Thu, 9 Oct 2014 15:35:05 -0400 [thread overview]
Message-ID: <20141009193504.GD415@peff.net> (raw)
In-Reply-To: <CAMsgyKb-ffkfqRhG-dUkwpnKOcA=3CrZqT57qcqTr+9zm_v2Jw@mail.gmail.com>
On Thu, Oct 09, 2014 at 12:53:33PM -0500, Derek Moore wrote:
> Following the INSTALL doc, I was building git with:
>
> make prefix=/usr/local all doc info
I wonder if it is actually sane to recommend building "info" for
newcomers in INSTALL. I do not know if many of the list regulars do so
(I certainly do not), or if it is part of anybody's testing regimen.
> $ git diff
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index cea0e7a..0e6c70a 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -107,7 +107,7 @@ HTML_REPO = ../../git-htmldocs
>
> MAKEINFO = makeinfo
> INSTALL_INFO = install-info
> -DOCBOOK2X_TEXI = docbook2x-texi
> +DOCBOOK2X_TEXI = db2x_docbook2texi
> DBLATEX = dblatex
> ASCIIDOC_DBLATEX_DIR = /etc/asciidoc/dblatex
> ifndef PERL_PATH
I don't think we would want to take a patch like this, as it is still
called docbook2x-texi at least on Debian.
You can override variables with:
make DOCBOOK2X_TEXI=db2x_docbook2texi ...
or if you want to use it for multiple make invocations:
echo DOCBOOK2_TEXI=db2x_docbook2texi >config.mak
If we want a patch to make this Just Work out of the box on Fedora, I'd
suggest looking at config.mak.uname (though I am not sure if there is
enough information there currently to determine Fedora versus another
distro), and/or a patch to configure.ac to detect which name we have.
-Peff
next prev parent reply other threads:[~2014-10-09 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 17:53 DOCBOOK2X_TEXI in Documentation/Makefile invalid on some distributions Derek Moore
2014-10-09 19:35 ` Jeff King [this message]
2014-10-09 19:40 ` Derek Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009193504.GD415@peff.net \
--to=peff@peff.net \
--cc=derek.p.moore@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).