From: David Aguilar <davvid@gmail.com>
To: Charles Bailey <charles@hashpling.org>
Cc: Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Sergio Ferrero <sferrero@ensoftcorp.com>
Subject: Re: [PATCH] mergetool: use more conservative temporary filenames
Date: Fri, 10 Oct 2014 11:23:13 -0700 [thread overview]
Message-ID: <20141010182312.GA78117@gmail.com> (raw)
In-Reply-To: <2DA99335-66B9-438E-A445-EB54B81EBE7A@hashpling.org>
On Fri, Oct 10, 2014 at 10:07:20AM +0100, Charles Bailey wrote:
> While you have the lid of this section of code, should we
> consider (optionally?) using a tmpdir to alleviate the eclipse
> issue where it wants temporary merge files to be the canonical
> locations for definitions of things that it finds when
> scanning source files in the project tree?
Hiding it behind mergetool.usetmpdir seems like a good idea.
That could be a good follow-up patch.
I don't use eclipse so I wasn't aware that this is an issue.
Thanks,
--
David
prev parent reply other threads:[~2014-10-10 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 8:56 [PATCH] mergetool: use more conservative temporary filenames David Aguilar
2014-10-09 18:36 ` Junio C Hamano
2014-10-10 8:10 ` David Aguilar
2014-10-10 9:07 ` Charles Bailey
2014-10-10 18:23 ` David Aguilar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141010182312.GA78117@gmail.com \
--to=davvid@gmail.com \
--cc=charles@hashpling.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sferrero@ensoftcorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).