From: Jeff King <peff@peff.net>
To: Ben Aveling <bena.001@optusnet.com.au>
Cc: Edward Thomson <ethomson@edwardthomson.com>, git@vger.kernel.org
Subject: Re: [RFC/PATCH] fsck: do not canonicalize modes in trees we are checking
Date: Tue, 14 Oct 2014 04:21:21 -0400 [thread overview]
Message-ID: <20141014082120.GA16686@peff.net> (raw)
In-Reply-To: <543B02A7.9040807@optusnet.com.au>
On Mon, Oct 13, 2014 at 09:37:27AM +1100, Ben Aveling wrote:
> A question about fsck - is there a reason it doesn't have an option to
> delete bad objects?
If the objects are reachable, then deleting them would create other big
problems (i.e., we would be breaking the object graph!).
If they are not, then it is probably safest for them to go away via the
normal means (repack/prune via "git gc"). Deleting via fsck would mean
replicating the reachability and deletion code found elsewhere.
-Peff
next prev parent reply other threads:[~2014-10-14 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 15:47 [RFC/PATCH] fsck: do not canonicalize modes in trees we are checking Jeff King
2014-09-23 16:23 ` Edward Thomson
2014-09-23 16:30 ` Jeff King
2014-10-12 22:37 ` Ben Aveling
2014-10-14 8:21 ` Jeff King [this message]
[not found] ` <543F074B.2050907@optusnet.com.au>
2014-10-16 0:20 ` Jeff King
2014-10-19 12:40 ` Ben Aveling
2014-10-20 9:21 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014082120.GA16686@peff.net \
--to=peff@peff.net \
--cc=bena.001@optusnet.com.au \
--cc=ethomson@edwardthomson.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).