From: "W. Trevor King" <wking@tremily.us>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git <git@vger.kernel.org>
Subject: Re: [PATCH] t1304: Set LOGNAME even if USER is unset or null
Date: Mon, 20 Oct 2014 08:28:09 -0700 [thread overview]
Message-ID: <20141020152809.GR17200@odin.tremily.us> (raw)
In-Reply-To: <xmqqegu3r7y7.fsf@gitster.dls.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On Sun, Oct 19, 2014 at 03:49:36PM -0700, Junio C Hamano wrote:
> I'll queue this as-is, but it makes me wonder if we want to do this
> without if/then/fi, e.g.
>
> : ${LOGNAME:=${USER:-$(id -u -n)}
I'm fine with that too.
> Spelling everything out with if/then/fi is obviously at the other
> extreme, i.e.
And I'm fine with this ;).
> More importantly, what if none of the alternatives work? I
> personally feel it is OK to punt and declare test_done early,
> instead of giving false positive breakages like you saw without this
> patch.
I can put this into a v2 if you like. Which conditional syntax do you
prefer?
Cheers,
Trevor
--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-20 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 21:39 [PATCH] t1304: Set LOGNAME even if USER is unset or null W. Trevor King
2014-10-19 22:49 ` Junio C Hamano
2014-10-20 15:28 ` W. Trevor King [this message]
2014-10-20 18:34 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141020152809.GR17200@odin.tremily.us \
--to=wking@tremily.us \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox