Git development
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: manjian2006@gmail.com
Cc: git@vger.kernel.org, Hin-Tak Leung <htl10@users.sourceforge.net>,
	Jakob Stoklund Olesen <stoklund@2pi.dk>
Subject: Re: [PATCH v3] git-svn: memoize _rev_list and rebuild
Date: Sat, 25 Oct 2014 05:44:26 +0000	[thread overview]
Message-ID: <20141025054426.GA31107@dcvr.yhbt.net> (raw)
In-Reply-To: <1390443319-11239-1-git-send-email-manjian2006@gmail.com>

manjian2006@gmail.com wrote:
> From: lin zuojian <manjian2006@gmail.com>
> 
> According to profile data, _rev_list and rebuild consume a large
> portion of time.  Memoize the results of _rev_list and memoize
> rebuild internals to avoid subprocess invocation.

Hi, I am considering reverting _rev_list memoization because it
can increases memory usage a lot, which hurting fork() performance on
Linux.

Can you tell me if your original results are under Linux or another
kernel?  I may only disable _rev_list memoization under Linux and
leave other OSes unaffected, too.

I've merged some patches from Jakob to improve svn:mergeinfo
performance along with some followup patches to reduce memory
use.  However memory bloat is still a problem.

Currently in my "master" branch of git://bogomips.org/git-svn

Eric Wong (4):
      git-svn: reduce check_cherry_pick cache overhead
      git-svn: cache only mergeinfo revisions
      git-svn: clear global SVN pool between get_log invocations
      git-svn: remove mergeinfo rev caching

Jakob Stoklund Olesen (2):
      git-svn: only look at the new parts of svn:mergeinfo
      git-svn: only look at the root path for svn:mergeinfo

      parent reply	other threads:[~2014-10-25 18:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23  2:15 [PATCH v3] git-svn: memoize _rev_list and rebuild manjian2006
2014-01-23  2:58 ` Eric Wong
2014-01-23 16:49   ` Junio C Hamano
2014-10-25  5:44 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141025054426.GA31107@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=git@vger.kernel.org \
    --cc=htl10@users.sourceforge.net \
    --cc=manjian2006@gmail.com \
    --cc=stoklund@2pi.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox