From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: David Michael <fedora.dm0@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule
Date: Tue, 28 Oct 2014 18:12:23 -0400 [thread overview]
Message-ID: <20141028221223.GA20722@peff.net> (raw)
In-Reply-To: <xmqq61f5flz6.fsf@gitster.dls.corp.google.com>
On Mon, Oct 27, 2014 at 10:42:21AM -0700, Junio C Hamano wrote:
> >> I believe I can work around the error with an "export _C89_CCMODE=1",
> >> but I thought I'd send the patch since this is the only occurrence of
> >> the problem, and the argument order is inconsistent with other linker
> >> commands in the file.
> >
> > I don't think working around it makes sense. That would fix your case,
> > but nobody else's (though given how long it has been that way without
> > complaints, I suspect any other compilers this picky may have died off).
>
> I think you meant s/nobody else's/breaks &/;
I meant "using the _C_89_CCMODE workaround does not help anybody else,
because their compiler will not support it; instead we should fix the
Makefile as David originally proposed".
I think we are still agreeing, though. :)
-Peff
prev parent reply other threads:[~2014-10-28 22:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 17:33 [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule David Michael
2014-10-26 17:45 ` Eric Sunshine
2014-10-26 18:35 ` Jeff King
2014-10-26 18:54 ` David Michael
2014-10-27 5:17 ` Jeff King
2014-10-27 17:42 ` Junio C Hamano
2014-10-28 22:12 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141028221223.GA20722@peff.net \
--to=peff@peff.net \
--cc=fedora.dm0@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).