git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Documentation for "git log --all" incorrect
@ 2014-10-29 11:51 Francis Irving
  2014-10-29 19:54 ` Jeff King
  0 siblings, 1 reply; 2+ messages in thread
From: Francis Irving @ 2014-10-29 11:51 UTC (permalink / raw)
  To: git

The help for "git log --all" says:

       --all
                  Pretend as if all the refs in refs/ are listed on
                  the command line as <commit>.

This makes no sense, as <commit> is not a documented valid command line
parameter. These are the documented parameters:

        SYNOPSIS
               git log [<options>] [<revision range>] [[--] <path>...]

Even if it means <revision range>, which is my best guess, it still
makes no sense as <revision range> cannot be a list of many refs.

I suspect both the documentation for "--all" and the documentation for
the basic options are either incorrect, or confusing by using multiple
names for the same thing.

I'm using git 1.9.2

Francis

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Documentation for "git log --all" incorrect
  2014-10-29 11:51 Documentation for "git log --all" incorrect Francis Irving
@ 2014-10-29 19:54 ` Jeff King
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2014-10-29 19:54 UTC (permalink / raw)
  To: Francis Irving; +Cc: git

On Wed, Oct 29, 2014 at 11:51:34AM +0000, Francis Irving wrote:

> The help for "git log --all" says:
> 
>        --all
>                   Pretend as if all the refs in refs/ are listed on
>                   the command line as <commit>.
> 
> This makes no sense, as <commit> is not a documented valid command line
> parameter. These are the documented parameters:
> 
>         SYNOPSIS
>                git log [<options>] [<revision range>] [[--] <path>...]
> 
> Even if it means <revision range>, which is my best guess, it still
> makes no sense as <revision range> cannot be a list of many refs.

The text for "--all" comes from rev-list-options.txt, which is included
in git-rev-list.txt and git-log.txt. It makes sense in the former but
not the latter. One fix would be to use "<commit>" in the synopsis for
git-log. But I think it would probably be OK to just drop the "as
<commit>" part of the --all text (and other related options need this,
too). It seems pretty clear to me without it.

Do you want to try your hand at a patch?

-Peff

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-29 19:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-29 11:51 Documentation for "git log --all" incorrect Francis Irving
2014-10-29 19:54 ` Jeff King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).