From: Jeff King <peff@peff.net>
To: John Szakmeister <john@szakmeister.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] diff-highlight: exit when a pipe is broken
Date: Tue, 4 Nov 2014 15:09:32 -0500 [thread overview]
Message-ID: <20141104200932.GA15149@peff.net> (raw)
In-Reply-To: <1415131272-89441-1-git-send-email-john@szakmeister.net>
On Tue, Nov 04, 2014 at 03:01:12PM -0500, John Szakmeister wrote:
> While using diff-highlight with other tools, I have discovered that Python
> ignores SIGPIPE by default. Unfortunately, this also means that tools
> attempting to launch a pager under Python--and don't realize this is
> happening--means that the subprocess inherits this setting. In this case, it
> means diff-highlight will be launched with SIGPIPE being ignored. Let's work
> with those broken scripts by restoring the default SIGPIPE handler.
>
> Signed-off-by: John Szakmeister <john@szakmeister.net>
> ---
> Incorporates feedback from Jeff King and now we just restore the default signal
> handler using the correct case of 'DEFAULT'.
Thanks, this version looks much simpler. :)
Acked-by: Jeff King <peff@peff.net>
-Peff
next prev parent reply other threads:[~2014-11-04 20:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 20:01 [PATCH v2] diff-highlight: exit when a pipe is broken John Szakmeister
2014-11-04 20:09 ` Jeff King [this message]
2014-11-04 20:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104200932.GA15149@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=john@szakmeister.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).