From: Jeff King <peff@peff.net>
To: Colin Smith <colin.webdev@gmail.com>
Cc: git@vger.kernel.org
Subject: [PATCH 0/2] approxidate and future ISO-like times
Date: Thu, 13 Nov 2014 06:03:25 -0500 [thread overview]
Message-ID: <20141113110325.GD8329@peff.net> (raw)
In-Reply-To: <20141113093606.GC8329@peff.net>
On Thu, Nov 13, 2014 at 04:36:06AM -0500, Jeff King wrote:
> On Thu, Nov 13, 2014 at 11:27:06AM +1100, Colin Smith wrote:
>
> > Apologies if this has already been raised or PEBCAK, but I've noticed
> > a bug where git log with certain date ranges breaks things. It appears
> > to be any --since date with a --until date in the future between
> > 2014-12-01 and 2014-12-09. Dates from 2014-12-10 appear to work, and
> > so does the date 2015-12-01.
>
> Ugh. Approxidate strikes again:
>
> for i in 2014-11-01 2013-12-01 2014-12-01; do
> ./test-date approxidate $i
> done
>
> produces:
>
> 2014-11-01 -> 2014-11-01 09:35:19 +0000
> 2013-12-01 -> 2013-12-01 09:35:19 +0000
> 2014-12-01 -> 2014-01-12 09:35:19 +0000
>
> The first two are right, but the fourth one is not. It's probably
> something simple and stupid.
Less simple and stupid than I thought, but I think I have a fix. It is
not about December specifically, but about the date being in the future.
The first patch is a cleanup to help us more accurately test the bug;
the interesting bits are in the second one.
[1/2]: pass TIME_DATE_NOW to approxidate future-check
[2/2]: approxidate: allow ISO-like dates far in the future
-Peff
next prev parent reply other threads:[~2014-11-13 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 0:27 Bug: git log showing nothing when using --since and --until flags with specific dates Colin Smith
2014-11-13 9:36 ` Jeff King
2014-11-13 11:03 ` Jeff King [this message]
2014-11-13 11:04 ` [PATCH 1/2] pass TIME_DATE_NOW to approxidate future-check Jeff King
2014-11-13 11:07 ` [PATCH 2/2] approxidate: allow ISO-like dates far in the future Jeff King
2014-11-13 21:11 ` Junio C Hamano
2014-11-13 21:36 ` Jeff King
2014-11-13 21:43 ` Jeff King
2014-11-13 22:36 ` Junio C Hamano
[not found] ` <CA+EOSBn0-ZFOPaeU92a0YWPW_S9kenoRUjJMp-Nhm-azftrEfA@mail.gmail.com>
2014-11-14 8:47 ` Jeff King
2014-11-14 22:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113110325.GD8329@peff.net \
--to=peff@peff.net \
--cc=colin.webdev@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).