From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Duy Nguyen <pclouds@gmail.com>,
Graeme Geldenhuys <mailinglists@geldenhuys.co.uk>,
git@vger.kernel.org
Subject: Re: Git archiving only branch work
Date: Thu, 13 Nov 2014 16:33:18 -0500 [thread overview]
Message-ID: <20141113213318.GA7563@peff.net> (raw)
In-Reply-To: <xmqqvbmizu12.fsf@gitster.dls.corp.google.com>
On Thu, Nov 13, 2014 at 01:10:17PM -0800, Junio C Hamano wrote:
> > How about just adding --stdin, which matches other git commands?
>
> How about doing nothing and use the correct $IFS instead?
Can you cover all cases with $IFS, including filenames with newlines?
I agree it is probably OK in practice and for the OP's question, but it
is nice to have "-z" variants so you do not have to worry about quoting
at all. I'd argue that a "--stdin -z" should probably also accept raw
filenames, not pathspecs, too (so you do not have to use
"--literal-pathspecs" elsewhere).
-Peff
next prev parent reply other threads:[~2014-11-13 21:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 12:32 Git archiving only branch work Graeme Geldenhuys
2014-11-13 13:19 ` Peter Krefting
2014-11-13 13:36 ` Duy Nguyen
2014-11-13 16:49 ` Junio C Hamano
2014-11-13 20:06 ` Jeff King
2014-11-13 21:10 ` Junio C Hamano
2014-11-13 21:33 ` Jeff King [this message]
2014-11-13 21:36 ` Junio C Hamano
2014-11-13 21:39 ` Jeff King
2014-11-13 21:48 ` Junio C Hamano
2014-11-14 15:32 ` Jeff King
2014-11-14 20:35 ` Junio C Hamano
2014-11-13 16:10 ` Thomas Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113213318.GA7563@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mailinglists@geldenhuys.co.uk \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).