From: Jeff King <peff@peff.net>
To: Elia Pinto <gitter.spiros@gmail.com>
Cc: Colin Smith <colin.webdev@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] approxidate: allow ISO-like dates far in the future
Date: Fri, 14 Nov 2014 03:47:25 -0500 [thread overview]
Message-ID: <20141114084725.GA16030@peff.net> (raw)
In-Reply-To: <CA+EOSBn0-ZFOPaeU92a0YWPW_S9kenoRUjJMp-Nhm-azftrEfA@mail.gmail.com>
On Fri, Nov 14, 2014 at 06:46:19AM +0100, Elia Pinto wrote:
> > [1] http://en.wikipedia.org/wiki/Date_and_time_representation_by_country
> > [2] http://en.wikipedia.org/wiki/Calendar_date
>
> Isn't not so good to refer to external resources in a commit message ?
It is not good to omit any explanation and just include a link, like:
Fixes the bug reported in http://...
because people who are reading "git log" have to follow that link to
even see what you are talking about (and the link might go away, or they
might not have access at the time).
It is fine, and even desirable, to summarize the relevant content of a
resource and provide a link for people who want to dig further. In this
case, I am saying "Wikipedia claims that nobody uses this format" and
backing it up with a link to indicate which pages I checked. You do not
have to follow the link to know what I am saying, but if you want to
dig deeper, you at least know where I left off my research.
Does that make sense?
-Peff
next prev parent reply other threads:[~2014-11-14 8:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 0:27 Bug: git log showing nothing when using --since and --until flags with specific dates Colin Smith
2014-11-13 9:36 ` Jeff King
2014-11-13 11:03 ` [PATCH 0/2] approxidate and future ISO-like times Jeff King
2014-11-13 11:04 ` [PATCH 1/2] pass TIME_DATE_NOW to approxidate future-check Jeff King
2014-11-13 11:07 ` [PATCH 2/2] approxidate: allow ISO-like dates far in the future Jeff King
2014-11-13 21:11 ` Junio C Hamano
2014-11-13 21:36 ` Jeff King
2014-11-13 21:43 ` Jeff King
2014-11-13 22:36 ` Junio C Hamano
[not found] ` <CA+EOSBn0-ZFOPaeU92a0YWPW_S9kenoRUjJMp-Nhm-azftrEfA@mail.gmail.com>
2014-11-14 8:47 ` Jeff King [this message]
2014-11-14 22:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141114084725.GA16030@peff.net \
--to=peff@peff.net \
--cc=colin.webdev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).