From: David Aguilar <davvid@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Adri Farr <14farresa@gmail.com>
Subject: Re: [PATCH] difftool: honor --trust-exit-code for builtin tools
Date: Fri, 14 Nov 2014 16:27:11 -0800 [thread overview]
Message-ID: <20141115002710.GA72216@gmail.com> (raw)
Adri sent me this directly but I think it should have gone to the list.
Adri, if you don't mind, Junio can add:
Tested-by: Adri Farr <14farresa@gmail.com>
...to the commit message trailer since it looks like it's happy.
Thanks for testing!
cheers,
David
----- Forwarded message from Adri Farr <14farresa@gmail.com> -----
Date: Sat, 15 Nov 2014 00:10:12 +0100
From: Adri Farr <14farresa@gmail.com>
To: David Aguilar <davvid@gmail.com>
Subject: Re: [PATCH] difftool: honor --trust-exit-code for builtin tools
I have tested this patch both in vim and meld and it works
wonderfully. Thank you for the time put into this. I should have
provided feedback back when the patch was proposed. I guess it's never
too late :).
2014-11-14 22:57 GMT+01:00 David Aguilar <davvid@gmail.com>:
> [snip]
----- End forwarded message -----
next reply other threads:[~2014-11-15 0:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-15 0:27 David Aguilar [this message]
2014-11-15 14:22 ` [PATCH] difftool: honor --trust-exit-code for builtin tools Adri Farr
-- strict thread matches above, loose matches on Subject: below --
2014-11-14 21:33 David Aguilar
2014-11-14 21:51 ` Junio C Hamano
2014-11-14 21:57 ` David Aguilar
2014-11-16 1:51 ` Mikael Magnusson
2014-11-16 2:36 ` David Aguilar
2014-11-16 18:11 ` Junio C Hamano
2014-11-16 8:18 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141115002710.GA72216@gmail.com \
--to=davvid@gmail.com \
--cc=14farresa@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).