git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brodie Rao <brodie@sf.io>,
	git@vger.kernel.org, Bryan Turner <bturner@atlassian.com>
Subject: Re: [PATCH] gc: support temporarily preserving garbage
Date: Mon, 17 Nov 2014 16:34:42 -0500	[thread overview]
Message-ID: <20141117213442.GD15880@peff.net> (raw)
In-Reply-To: <xmqqlhnd1j66.fsf@gitster.dls.corp.google.com>

On Fri, Nov 14, 2014 at 03:01:05PM -0800, Junio C Hamano wrote:

> >  23 files changed, 375 insertions(+), 7 deletions(-)
> [...]
> 
> I am not sure if this much of code churn is warranted to work around
> issues that only happen on repositories on NFS servers that do not
> keep open-but-deleted files available.  Is it an option to instead
> have a copy of repository locally off NFS?

I think it is also not sufficient. This patch seems to cover only
objects. But we assume that we can atomically rename() new versions of
files into place whenever we like without disrupting existing readers.
This is the case for ref updates (and packed-refs), as well as the index
file.  The destination end of the rename is an unlink() in disguise, and
would be susceptible to the same problems.

-Peff

  parent reply	other threads:[~2014-11-17 21:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14  1:16 [PATCH] gc: support temporarily preserving garbage Brodie Rao
2014-11-14 23:01 ` Junio C Hamano
2014-11-15  1:49   ` Stefan Saasen
2014-11-17 21:34   ` Jeff King [this message]
2014-11-17 23:59     ` Stefan Saasen
2014-11-18  0:21       ` Jeff King
2014-12-03 21:21     ` Brodie Rao
2014-12-04  9:10       ` Jeff King
2014-12-04 18:04         ` Junio C Hamano
2014-12-05  9:30           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141117213442.GD15880@peff.net \
    --to=peff@peff.net \
    --cc=brodie@sf.io \
    --cc=bturner@atlassian.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).